Conversation
Collaborator
commit: 68b15ba |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPS-402
DESCRIPTION
Problem:
The ticket mentions that we should implement the same functionality as in the https://perconadev.atlassian.net/browse/K8SPXC-1366.
Solution:
1. New
allowParallelfieldThis PR adds
spec.backup.allowParallelto the clusterallowParallelcontrols whether multiple backups for the same cluster may run at the same timefalse, the operator uses a backup lease allowing only one backup to run at a timetrue, the operator does not use the lease, allowing multiple backup Jobs to run concurrently2. New
startingDeadlineSecondsfieldThis PR adds
spec.backup.startingDeadlineSecondsto the cluster andspec.startingDeadlineSecondsto backup CRsstartingDeadlineSecondsdefines how long a backup may wait before its job is created.The deadline is measured from the backup creation time while the backup remains in the
NeworStartingstate without a job.Errorand releases its backup lease.With these changes operator will keep the backup pending if cluster is unready until it becomes ready or
startingDeadlineSecondsexpires, instead of setting it toErrorstate3. New
suspendedDeadlineSecondsfieldThis PR adds
spec.backup.suspendedDeadlineSecondsto the cluster andspec.suspendedDeadlineSecondsto backup CRssuspendedDeadlineSecondsdefines how long a suspended backup job may wait for the cluster to become ready again.When the backup is active and cluster becomes non-ready, the operator suspends the backup job, changes the backup state to
Suspended, and starts measuring the deadline from the job'sJobSuspended=Truetransition time.Failed, deletes the suspended job, and releases its backup lease.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability