Skip to content

K8SPS-387 add wait_for_delete function #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

K8SPS-387 add wait_for_delete function #915

merged 3 commits into from
May 27, 2025

Conversation

gkech
Copy link
Contributor

@gkech gkech commented May 27, 2025

K8SPS-387 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Adding the functionwait_for_delete that is used by create_namespace and is missing because we didn't provide OC support until now.

Note: used the same implementation with the one we have in the PXC operator.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label May 27, 2025
@gkech gkech marked this pull request as ready for review May 27, 2025 11:03
@hors hors self-requested a review May 27, 2025 12:56
exit 1
fi
done
set_debug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkech we do not have set_debug in PS.

Copy link
Contributor Author

@gkech gkech May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, noticed it in Jenkins as well when executed an OC test to verify this

Screenshot 2025-05-27 at 4 56 08 PM

will remove it

@gkech gkech requested a review from hors May 27, 2025 13:58
@hors hors merged commit c8323fe into main May 27, 2025
4 of 5 checks passed
@hors hors deleted the K8SPS-387 branch May 27, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants