Skip to content

(8.4) PS-9647: MySQL Perf Improvements (inline)#5639

Merged
inikep merged 1 commit into
percona:8.4from
kamil-holubicki:PS-9647-inline-8.4
Jul 28, 2025
Merged

(8.4) PS-9647: MySQL Perf Improvements (inline)#5639
inikep merged 1 commit into
percona:8.4from
kamil-holubicki:PS-9647-inline-8.4

Conversation

@kamil-holubicki

Copy link
Copy Markdown
Contributor

https://perconadev.atlassian.net/browse/PS-9647

Cherry pick commit 45fc6df

Make the following functions inline using the 'always_inline' attribute

  1. row_mysql_store_col_in_innobase_format_func()
  2. row_mysql_store_col_in_innobase_format()
  3. rec_init_offsets_new()
  4. Move the definitions of row_mysql_store_col_in_innobase_format() and row_mysql_store_col_in_innobase_format_func() to row0sel.ic

NOTE:
This forceful inlining increases the binary size by 10 kBs.

Before the change (debug): 802135752
After the change (debug): 802146560
Increase in binary size: 10808 bytes

https://perconadev.atlassian.net/browse/PS-9647

Cherry pick commit 45fc6df

Make the following functions inline using the 'always_inline' attribute

1. row_mysql_store_col_in_innobase_format_func()
2. row_mysql_store_col_in_innobase_format()
3. rec_init_offsets_new()
4. Move the definitions of row_mysql_store_col_in_innobase_format() and
   row_mysql_store_col_in_innobase_format_func() to row0sel.ic

NOTE:
This forceful inlining increases the binary size by 10 kBs.

Before the change (debug): 802135752
After the change (debug): 802146560
Increase in binary size: 10808 bytes
@kamil-holubicki kamil-holubicki changed the title (8.4) PS-9647: MySQL Perf Improvements (8.4) PS-9647: MySQL Perf Improvements (inline) Jun 25, 2025

@percona-ysorokin percona-ysorokin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inikep
inikep merged commit 0fac32d into percona:8.4 Jul 28, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants