PS-10102 [9.7] Fix of tests for component_keyring_kmip and crashes of component when a KMIP server inaccessible#6104
Open
lukin-oleksiy wants to merge 2 commits into
Conversation
https://perconadev.atlassian.net/browse/PS-10102 When component_keyring_kmip is loaded but keyring initialization fails (e.g. KMIP server not running or misconfigured), g_keyring_operations remains a null unique_ptr. Any subsequent call to a keyring service method (generate, store, remove, read, encrypt, decrypt, iterator) dereferences this null pointer, triggering an assertion in unique_ptr::operator*() and aborting the server. Add a null guard at the start of every service method that dereferences g_keyring_operations, returning true (error) immediately when the keyring has not been successfully initialized.
https://perconadev.atlassian.net/browse/PS-10102 Various fixes of component_keyring_kmip MTR tests to run successfully on PyKMIP and CosmianKMS servers. Some tests are excluded from parallel run. The CosmianKMS KMIP server now is main for testing, but PyKMIP server is still supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 2 commits: First fixes crashed in the situation when a KMIP server inaccessible; Second commit fixes tests suite for component_keyring_kmip