Skip to content

[trunk] PXB-3458 : Ignore invalid innodb_undo_directory setting in --copy-back mode #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satya-bodapati merged 1 commit into from
Jan 18, 2026
Merged

[trunk] PXB-3458 : Ignore invalid innodb_undo_directory setting in --copy-back mode #1718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions storage/innobase/xtrabackup/src/backup_copy.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ struct datadir_thread_ctxt_t {
bool ret;
};


/************************************************************************
Trim leading slashes from absolute path so it becomes relative */
static const char *trim_dotslash(const char *path) {
Expand Down Expand Up @@ -2290,7 +2289,15 @@ bool copy_back(int argc, char **argv) {

/* copy undo tablespaces */
if (srv_undo_tablespaces > 0) {
dst_dir = (srv_undo_dir && *srv_undo_dir) ? srv_undo_dir : mysql_data_home;
dst_dir = mysql_data_home;

// If innodb_undo_directory is set, use it as the destination directory.
// Ignore innodb_undo_directory if it's set to "./" (default value), because
// it will make xtrabackup try to copy files back to backup directory,
// resulting in "file exists" errors.
if (srv_undo_dir && *srv_undo_dir && strcmp(srv_undo_dir, "./") != 0) {
dst_dir = srv_undo_dir;
}

ds_data = ds_create(dst_dir, DS_TYPE_LOCAL);

Expand Down