PXB-2553 [8.4]: Fix stacktrace assertion in bug766305 test - #1788
Merged
jakub-nowakowski-percona merged 1 commit intoSep 3, 2026
Merged
Conversation
https://perconadev.atlassian.net/browse/PXB-2553 Problem: -------- The test sends SIGSEGV to xtrabackup and verifies a resolved stack trace is produced. The assertion grepped for "handle_fatal_signal", which only appears when the signal handler frame is resolved as a symbol in the backtrace. This is platform- and compiler-dependent: the signal is delivered to an arbitrary thread, and the backtrace shows that thread's stack, not the signal handler's frame. Fix: ---- Replace the assertion with a regex matching any resolved stack frame with a source location ("... <symbol> at ..."), which is always present regardless of which thread receives the signal.
Contributor
Author
satya-bodapati
approved these changes
Sep 2, 2026
jakub-nowakowski-percona
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PXB-2553
Problem:
The test sends SIGSEGV to xtrabackup and verifies a resolved stack trace is produced. The assertion grepped for "handle_fatal_signal", which only appears when the signal handler frame is resolved as a symbol in the backtrace. This is platform- and compiler-dependent: the signal is delivered to an arbitrary thread, and the backtrace shows that thread's stack, not the signal handler's frame.
Fix:
Replace the assertion with a regex matching any resolved stack frame with a source location ("... at ..."), which is always present regardless of which thread receives the signal.