PXC-4676: Code refresh for - PXC 8.4.5 (Fixed MYSQL_MAINTAINER_MODE=ON build.)#2120
Merged
kamil-holubicki merged 1 commit intoJun 10, 2025
Conversation
https://perconadev.atlassian.net/browse/PXC-4676 Fixed MYSQL_MAINTAINER_MODE=ON build. When mysqlbinlog.cc was compiled, WITH_WSREP was undefined. It caused One Definition Rule violation, because handler.h is included indirectly in several compilation units and it contains legacy_db_type that has values conditionally compiled in (WITH_WSREP). There is no reason why WITH_WSREP should be undefined for mysqlbinlog.cc
kamil-holubicki
force-pushed
the
PXC-4676-maint-mode-fix
branch
from
June 9, 2025 14:07
bc3117b to
ae32ec0
Compare
kamil-holubicki
merged commit Jun 10, 2025
2050d77
into
percona:release-8.4.5
19 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PXC-4676
Fixed MYSQL_MAINTAINER_MODE=ON build.
When mysqlbinlog.cc was compiled, WITH_WSREP was undefined. It caused One Definition Rule violation, because handler.h is included indirectly in several compilation units and it contains legacy_db_type that has values conditionally compiled in (WITH_WSREP).
There is no reason why WITH_WSREP should be undefined for mysqlbinlog.cc