Simplify shared memory size calculations#782
Merged
Merged
Conversation
jeltz
force-pushed
the
simplify-shmem-size
branch
from
July 11, 2026 08:36
2273199 to
73a7e6f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
==========================================
+ Coverage 87.59% 87.80% +0.20%
==========================================
Files 3 3
Lines 1314 1320 +6
Branches 187 187
==========================================
+ Hits 1151 1159 +8
+ Misses 80 79 -1
+ Partials 83 82 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jeltz
force-pushed
the
simplify-shmem-size
branch
from
July 13, 2026 07:24
73a7e6f to
9426722
Compare
We calculated the shared memory size in an unnecessarily convoluted way. While as it move all calculations from macros to functions.
jeltz
force-pushed
the
simplify-shmem-size
branch
from
July 13, 2026 07:30
9426722 to
6382864
Compare
artemgavrilov
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We calculated the shared memory size in an unnecessarily convoluted way. I am still a bit skeptical we should access GUCs in macros but this is at least a bit easier to read.
PG-0