Do not leave pgsm_create_view() after CREATE EXTENSION#794
Merged
Conversation
jeltz
force-pushed
the
rm-pgsm-create-view
branch
2 times, most recently
from
July 16, 2026 10:40
6a6dac6 to
53697e9
Compare
This function has no use to any user and just pollutes the catalog and public namespace for no reason. A DO block is simpler and does not leave anything behind.
jeltz
force-pushed
the
rm-pgsm-create-view
branch
from
July 16, 2026 10:46
53697e9 to
f6662fc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 88.14% 88.29% +0.15%
==========================================
Files 3 3
Lines 1307 1307
Branches 184 184
==========================================
+ Hits 1152 1154 +2
+ Misses 75 74 -1
+ Partials 80 79 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dutow
approved these changes
Jul 16, 2026
artemgavrilov
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function has no use to any user and just pollutes the catalog and public namespace for no reason. A DO block is simpler and does not leave anything behind.
PG-0