PG-2125: Switching kmip support to the new C++ kmip client library#595
Merged
Conversation
dutow
force-pushed
the
libkmip-rework
branch
3 times, most recently
from
June 1, 2026 18:12
e5ca208 to
bf387f1
Compare
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (76.56%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
==========================================
- Coverage 56.74% 56.68% -0.07%
==========================================
Files 72 71 -1
Lines 11297 11236 -61
Branches 2781 2778 -3
==========================================
- Hits 6411 6369 -42
+ Misses 3525 3502 -23
- Partials 1361 1365 +4
🚀 New features to boost your workflow:
|
dutow
force-pushed
the
libkmip-rework
branch
2 times, most recently
from
June 16, 2026 22:37
405c686 to
bf78991
Compare
dutow
changed the title
dAdAbird
reviewed
Jun 17, 2026
dAdAbird
left a comment
dAdAbird
left a comment
Member
There was a problem hiding this comment.
LGTM overall, I'm just not sure about the pgindent scope change
jeltz
requested changes
Jul 6, 2026
jeltz
approved these changes
Jul 14, 2026
jeltz
left a comment
jeltz
left a comment
Collaborator
There was a problem hiding this comment.
Approved, but see my comment on Slack about way forward.
This commit updates the submodule pointer for kmip and reworks our code to use a new C++ api instead of the old and buggy C api.
The backend failed to load pg_tde.so under sanitizers with "undefined symbol: __ubsan_vptr_type_cache", so every test that starts a server errored. That symbol is provided only by the C++-only UBSan runtime (ubsan_standalone_cxx), which is not linked into the C postgres backend that dlopens the module. Disable the vptr check for the C++ objects and build the C++ sources/links with the sanitizer flags (CXX=clang++) so a single clang ASan/UBSan runtime is used throughout. Drop the ASAN_SYMBOLIZER_PATH override: /usr/bin/llvm-symbolizer-14 does not exist on the runner, so ASan could not symbolize its reports; without the override it finds a working llvm-symbolizer in PATH. Ignore geninfo "mismatch" errors in the coverage job: geninfo reports them on the coverage data of the C++ objects, and lcov 2.x treats them as fatal by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the submodule pointer for kmip and reworks our code to use a new C++ api instead of the old and buggy C api.