Fix FB tests for PMM-15194 encryption v2 rotation#1046
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
travagliad
marked this pull request as ready for review
July 4, 2026 12:46
travagliad
marked this pull request as draft
July 8, 2026 03:35
Contributor
|
@cursoragent separate these 2 fixes into 2 different PRs, leave the one for the encryption as draft, and the other as open. |
Contributor
Author
|
Split complete. The combined PR is now two focused PRs: Draft — encryption only#1046 — Fix FB tests for PMM-15194 encryption v2 rotation (draft)
Open — podman workflow only#1058 — Fix podman e2e workflow apt setup on Ubuntu jammy (ready for review)
The CLI remove error message fix was already merged separately in #1045, so it isn’t part of either PR. Both branches are rebased on current   |
Update verifyEncryptionRotation() assertions to match the new keyset-based rotation output: primary key added, PMM Server restarted, and secrets re-encrypted with the new key. Co-authored-by: travagliad <travagliad@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/pmm-fb-test-repair-ea1a
branch
from
July 9, 2026 12:00
ce5b797 to
a63c6b9
Compare
Contributor
|
Warning This is dependent on percona/pmm#5595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
FB run 28705517533 on PR-4456 (PMM-15194 migrate encryption to v2) failed three suites:
DB pmm-managed is successfully decrypted, etc.) removed in PMM-15194 Rewrite field-level encryption on tink-go/v2 pmm#5595We could not find... Please) but pmm-admin now printscould not find...; pleaselibncurses5beforeapt-get update, hitting a 404 on jammy mirrors; also had a broken emptyapt-get installlineHow
verifyEncryptionRotation()inencryption_test.jsto assert v2 rotation output: primary key added, PMM Server restarted, secrets re-encryptedremove.spec.tsexpected CLI error message withadmin/commands/management/remove.gorunner-e2e-tests-podman.yml: runapt-get updatefirst, replacelibncurses5withlibncurses6, remove broken empty install step