PMM-14109 Improve Advisor UX#1083
Open
ademidoff wants to merge 2 commits into
Open
Conversation
Advisor settings moved out of the Advanced settings tab into a dedicated Advisors tab (/pmm-ui/settings/advisors) in pmm-ui. Point the codeceptjs settings page object and specs, plus the Playwright HA settings page, at the new tab and the renamed advisors-* test ids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to percona/pmm#5656, which moves the Advisor settings out of the Advanced settings tab into a dedicated Advisors tab (
/pmm-ui/settings/advisors).Changes
codeceptjs-e2e/tests/configuration/pages/pmmSettingsPage.js: addadvisorsSettingsUrlandopenAdvisorsSettings(), add theadvisorsentry tosectionTabsList/expandSection, add theadvisorsButton($advisors-button) field, and rename the section test ids ($advanced-advisors→$advisors-settings,$advanced-advisors-label-description→$advisors-label-description).verifyPMMSettingsPageElements_test.js: split the advisor assertions into a new "Verify Advisors Section Elements" scenario that opens the Advisors tab.verifyPMMSettingsPageFunctionality_test.js,advisors/stt/sttSettings_test.js,upgrade/advisorsAlerting_test.js: navigate to the Advisors tab and apply changes viaadvisorsButton.e2e_tests/pages/ha/settings.page.ts: route theadvisorstoggle to the Advisors tab and apply viaadvisors-button.Field-level test ids (interval inputs, retention, severity threshold,
switch-input-stt) are unchanged — they just live under the new tab now.Note:
databaseChecks_test.js(skipped) still asserts the legacy "checks disabled" link points at/settings/advanced-settings; that link is rendered by the legacy Grafana checks UI and is out of scope for this change.