Skip to content

Fix Dependabot setuptools security update in qa-integration#1097

Open
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/pmm-fb-test-repair-29d8
Open

Fix Dependabot setuptools security update in qa-integration#1097
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/pmm-fb-test-repair-29d8

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Why

Dependabot security updates for setuptools in qa-integration/pmm_qa were failing on main with dependency_file_not_supported. The setuptools>=65.0.0,<74 constraint blocked the patched version (83.0.0) required by GHSA security advisories.

How

  • Bumped setuptools constraint to >=83.0.0,<84 in qa-integration/pmm_qa/requirements.txt
  • Verified pip install -r requirements.txt resolves to setuptools 83.0.0
Open in Web View Automation 

@travagliad
travagliad marked this pull request as ready for review July 22, 2026 13:16
@travagliad

Copy link
Copy Markdown
Contributor

@cursoragent I guess you didn't checked the pipeline 😞

@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

You're right — the pipeline wasn't checked properly.

The setuptools bump to >=83.0.0,<84 was correct for the Dependabot security fix, but it broke CI. In the E2E workflows, pmm-framework.py failed during provisioning with:

ModuleNotFoundError: No module named 'pkg_resources'

Root cause: setuptools 82+ removed pkg_resources, but ansible-runner==2.3.2 still imports it at startup. pip install -r requirements.txt succeeded, so the earlier verification missed the runtime failure.

Fix pushed: bumped ansible-runner from 2.3.2 to 2.3.8 (the first patch release that works with setuptools 83). Verified in a fresh venv that:

  • setuptools resolves to 83.0.0
  • pmm-framework.py imports succeed

The branch is rebased on main and pushed. CI should re-run on the updated PR.

Open in Web Open in Cursor 

cursoragent and others added 2 commits July 22, 2026 14:14
Bump setuptools constraint from <74 to >=83.0.0,<84 to address
GHSA security advisories. Dependabot could not auto-update because
the upper bound blocked the patched version.

Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
ansible-runner 2.3.2 imports pkg_resources, which setuptools 82+
removed. Bump ansible-runner to 2.3.8 so pmm-framework.py can run in
CI venvs with the Dependabot-required setuptools constraint.

Co-authored-by: travagliad <travagliad@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/pmm-fb-test-repair-29d8 branch from e1ff901 to b010927 Compare July 22, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants