Increase job timeout for RC testing queue wait#1099
Closed
travagliad wants to merge 5 commits into
Closed
Conversation
RC testing dispatches dozens of parallel jobs that queue for GitHub-hosted runners. Job timeout-minutes includes queue wait time, so the default 40-minute limit cancels jobs before they start. Use 120 minutes when the PMM server image tag contains -rc, which is how rc-testing-suite identifies RC builds. Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
Replace -rc image detection across multiple workflows with a job_timeout_minutes input on the CLI runner. RC testing passes 120; all other callers keep the default 40-minute limit. Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
Propagate the optional job_timeout_minutes parameter through E2E, GSSAPI, FB, package-test, and QA integration workflows. RC testing suite passes 120 for every job that had an explicit low timeout; helm is unchanged (uses the GitHub default 6h limit). Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
Remove duplicate job_timeout_minutes entries accidentally inserted into commented job blocks during bulk propagation. Add the parameter to the podman E2E runner so fb-e2e-suite can forward it safely. Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
GitHub rejects an empty string for number-type workflow_call inputs. Forward 0 when unset so runners keep their existing defaults via ||. Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RC testing fans out 50+ parallel jobs.
timeout-minutesincludes queue wait time, so jobs with low explicit limits (20–90 min) were cancelled before a runner was assigned.Fix
Add an optional
job_timeout_minutesinput to each affected runner/QA workflow (defaults to the previous value when omitted). Onlyrc-testing-suite.ymlpassesjob_timeout_minutes: 120.integration-cli-tests→ CLI runnere2e-tests-matrix→ codeceptjs/playwright/fb runnersgssapi-psmdb-tests-matrix→ all runnersHelm was left out on purpose: it never had a low explicit timeout, so passing 120 would have reduced its budget from 6h.
Test plan