Skip to content

Match rule-template rows by cell text, not direct text node #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
travagliad merged 3 commits into from
Sep 3, 2026
+10 −8
Merged

Match rule-template rows by cell text, not direct text node #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50c8416
Match rule-template rows by cell text, not direct text node
travagliad Sep 2, 2026
43a996f
Address review: inline the one-line helper, drop dead code
travagliad Sep 2, 2026
5e7a38a
Scope the row match to the name column, matched exactly
travagliad Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions codeceptjs-e2e/tests/ia/pages/ruleTemplatesPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
const { I } = inject();
const YAML = require('yaml');

const templateRow = (templateName) => `//tr[td[contains(., "${templateName}")]]`;
// Scoped to the name column and matched exactly: the name renders as the cell's own text,
// or nested in an element once a template carries a badge.
const templateRow = (templateName) => `//tr[td[1][text()[normalize-space() = "${templateName}"] or .//*[normalize-space(text()) = "${templateName}"]]]`;

module.exports = {
url: 'graph/alerting/alert-rule-templates',
Expand All @@ -14,7 +16,6 @@ module.exports = {
templateName: '//tr/td[1]',
modalHeader: '$modal-header',
modalWarning: '$alert-rule-name-warning',
templateRowByName: (name) => templateRow(name),
templateRowBySource: (source) => `//tr[descendant::div[contains(text(), "${source}")]]`,
columnHeaderLocator: (columnHeaderText) => `//th[text()="${columnHeaderText}"]`,
unathorizedMessage: '$unauthorized',
Expand All @@ -31,11 +32,9 @@ module.exports = {
editButtonBySource: (source) => `//tr[descendant::div[contains(text(), "${source}")]]//button[@data-testid="edit-template-button"]`,
// deleteButtonBySource returns Delete template button locators for a given source
deleteButtonBySource: (source) => `//tr[descendant::div[contains(text(), "${source}")]]//button[@data-testid="delete-template-button"]`,
// editButtonByName returns Delete template button locator for a given Template name
editButtonByName: (name) => `//td[contains(text(), "${name}")]/following-sibling::td//button[@data-testid="edit-template-button"]`,
// deleteButtonByName returns Delete template button locator for a given Template name
deleteButtonByName: (name) => `//td[contains(text(), "${name}")]/following-sibling::td//button[@data-testid="delete-template-button"]`,
addRuleButtonByName: (name) => `//td[contains(text(), "${name}")]/following-sibling::td//a[@data-testid="create-from-template-button"]`,
editButtonByName: (name) => `${templateRow(name)}//button[@data-testid="edit-template-button"]`,
deleteButtonByName: (name) => `${templateRow(name)}//button[@data-testid="delete-template-button"]`,
addRuleButtonByName: (name) => `${templateRow(name)}//a[@data-testid="create-from-template-button"]`,
Comment thread
travagliad marked this conversation as resolved.
Comment thread
travagliad marked this conversation as resolved.
},
fields: {
templateInput: locate('$yaml-textarea-input'),
Expand Down
5 changes: 4 additions & 1 deletion codeceptjs-e2e/tests/ia/ruleTemplates_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,10 @@ Scenario(
'PMM-T1514 - Verify that alert rule templates has only 1 exit button @fb-alerting',
async ({ I, ruleTemplatesPage, alertRulesPage }) => {
ruleTemplatesPage.openRuleTemplatesTab();
ruleTemplatesPage.openAddDialog(await I.grabTextFrom(ruleTemplatesPage.elements.templateName));
// The name cell also carries a "Dynamic" badge for overridable templates.
const [name] = (await I.grabTextFrom(ruleTemplatesPage.elements.templateName)).split('\n');

ruleTemplatesPage.openAddDialog(name.trim());
I.dontSeeElement('//button[span[text()="Save"]]');
I.seeElement(alertRulesPage.buttons.saveAndExit);
},
Expand Down
Loading