Skip to content

Unskip PMM-T506 once its stale expectations are gone - #1310

Closed
travagliad wants to merge 1 commit into
mainfrom
claude/unskip-t506
Closed

Unskip PMM-T506 once its stale expectations are gone#1310
travagliad wants to merge 1 commit into
mainfrom
claude/unskip-t506

Conversation

@travagliad

Copy link
Copy Markdown
Contributor

Failures fixed (investigator)

What this is

The second half of the fix. #1288 muted PMM-T506 while the panel question was open; #1275 (now
approved) settles it by dropping the two expectations. This removes the mute so the test runs again.

-// skip-until: 2026-09-29 -- cardinality panels removed by percona/pmm#5822; unskip via pmm-qa#1275, or when the panels return.
-Scenario.skip(
+Scenario(

Why this is a separate PR, and why it is needed at all

#1275 alone no longer fixes the nightly. Its branch forked from 0b9d4d9, before #1288 landed,
so its copy of verifyVMDashboards_test.js still reads a plain Scenario( — nothing to unskip on
that side. In the three-way merge the base and that branch agree on the file while main added the
skip, so merging #1275 keeps Scenario.skip: expectations fixed, test still dark, nightly
unchanged, and the skip-until: 2026-09-29 tripwire fires on a test nobody needs to look at any more.

The alternative was to merge main into #1275's branch and unskip there — one atomic merge. Not done
for two reasons: it would reset the approval #1275 just received, and #1275 was explicitly asked to be
left alone to be merged or rejected on its own. A GitHub App also can't push that merge, since it
would touch .github/workflows/lint.yml (moved by #1288) — see the analysis on #1275.

Kept as a draft so it cannot merge out of order.

Merge order

  1. Drop the cardinality panel expectations and unskip PMM-T506 #1275 — drops the stale expectations.
  2. this — removes the mute; T506 runs against the corrected expectations.

Reversed, step 2 alone reproduces the original failure for a night.

Verification

The guard and weekly lint schedule from #1288 stay in place for future skips; only this skip and its
marker are removed.


🤖 Generated with Claude Code

https://claude.ai/code/session_01SKRuqWTQVW4p6DDSYcFQEf


Generated by Claude Code

pmm-qa#1288 muted PMM-T506 while the VictoriaMetrics panel question was
open. pmm-qa#1275 settles it by dropping the two expectations the panels
no longer satisfy, so the mute has done its job.

Removes Scenario.skip and the skip-until marker, restoring the file
byte-for-byte to its pre-mute state. Must land after #1275: on its own
the test would run against expectations that are still stale and fail
exactly as it did before the mute.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SKRuqWTQVW4p6DDSYcFQEf
Signed-off-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants