Unskip PMM-T506 once its stale expectations are gone - #1310
Closed
travagliad wants to merge 1 commit into
Closed
Conversation
pmm-qa#1288 muted PMM-T506 while the VictoriaMetrics panel question was open. pmm-qa#1275 settles it by dropping the two expectations the panels no longer satisfy, so the mute has done its job. Removes Scenario.skip and the skip-until marker, restoring the file byte-for-byte to its pre-mute state. Must land after #1275: on its own the test would run against expectations that are still stale and fail exactly as it did before the mute. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SKRuqWTQVW4p6DDSYcFQEf Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failures fixed (investigator)
codeceptjs-e2e/tests/verifyVMDashboards_test.js:9/@nightly— PMM-T506 Verify metrics on VictoriaMetrics dashboardWhat this is
The second half of the fix. #1288 muted PMM-T506 while the panel question was open; #1275 (now
approved) settles it by dropping the two expectations. This removes the mute so the test runs again.
Why this is a separate PR, and why it is needed at all
#1275 alone no longer fixes the nightly. Its branch forked from
0b9d4d9, before #1288 landed,so its copy of
verifyVMDashboards_test.jsstill reads a plainScenario(— nothing to unskip onthat side. In the three-way merge the base and that branch agree on the file while
mainadded theskip, so merging #1275 keeps
Scenario.skip: expectations fixed, test still dark, nightlyunchanged, and the
skip-until: 2026-09-29tripwire fires on a test nobody needs to look at any more.The alternative was to merge
maininto #1275's branch and unskip there — one atomic merge. Not donefor two reasons: it would reset the approval #1275 just received, and #1275 was explicitly asked to be
left alone to be merged or rejected on its own. A GitHub App also can't push that merge, since it
would touch
.github/workflows/lint.yml(moved by #1288) — see the analysis on #1275.Kept as a draft so it cannot merge out of order.
Merge order
Reversed, step 2 alone reproduces the original failure for a night.
Verification
git diff --quiet 0b9d4d9 -- <file>→ clean),so this is a true revert of Mute PMM-T506 behind an expiring skip #1288's test change, not a rewrite.
skip-untilmarker remains anywhere: 0 of 393 tracked.js/.tsfiles carry one, so the guardMute PMM-T506 behind an expiring skip #1288 added has nothing dangling to fire on.
skip-until expirycheck still runs clean over all tracked files (rc=0).✖rather thanS— it executes instead of being skipped (it fails in thissandbox only because there is no PMM server to reach).
green with the expectations dropped and the scenario active — which is exactly
main+ Drop the cardinality panel expectations and unskip PMM-T506 #1275 + this.The guard and weekly lint schedule from #1288 stay in place for future skips; only this skip and its
marker are removed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SKRuqWTQVW4p6DDSYcFQEf
Generated by Claude Code