Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #4926 +/- ##
==========================================
- Coverage 45.85% 45.83% -0.02%
==========================================
Files 367 367
Lines 38531 38531
==========================================
- Hits 17669 17662 -7
- Misses 19163 19170 +7
Partials 1699 1699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR integrates the Percona UI library (@percona/percona-ui) into PMM, replacing the previous internal theme implementation and UI component organization. The integration consolidates theme definitions, updates Material-UI imports, and removes deprecated custom theme code.
Changes:
- Replaces
@percona/designand@percona/ui-libpackages with the unified@percona/percona-uipackage - Removes internal Peak Design System theme definitions in favor of the external library's implementation
- Updates TypeScript configuration to use local settings instead of external package configurations
- Standardizes Material-UI component imports across the codebase
Reviewed changes
Copilot reviewed 62 out of 63 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/tsconfig.json | Updates to reference local shared TypeScript configuration |
| ui/packages/shared/tsconfig.json | Expands inline TypeScript compiler options, removing external package dependency |
| ui/packages/shared/src/types.ts | Changes ColorMode type to use Material-UI's PaletteMode |
| ui/packages/shared/src/theme/peak-ds.ts | Removes entire Peak Design System theme definitions (408 lines) |
| ui/packages/shared/src/theme/index.ts | Removes theme exports |
| ui/packages/shared/src/index.ts | Removes theme re-export |
| ui/packages/shared/package.json | Removes @percona/tsconfig dependency |
| ui/packages/shared/.eslintrc.cjs | Expands ESLint configuration inline |
| ui/package.json | Adds workspaces nohoist configuration for react-router-dom |
| ui/apps/pmm/vitest.config.ts | Creates new test configuration with React deduplication and percona-ui inline support |
| ui/apps/pmm/vite.config.ts | Adds React deduplication, optimizeDeps force, and watch configuration for linked packages |
| ui/apps/pmm/src/utils/testWrapper.tsx | Updates to import theme from percona-ui |
| ui/apps/pmm/src/types/util.types.ts | Standardizes SvgIcon import |
| ui/apps/pmm/src/types/navigation.types.ts | Standardizes ChipProps import |
| ui/apps/pmm/src/themes/PmmTheme.tsx | Removes entire PMM theme implementation (255 lines) |
| ui/apps/pmm/src/pages/updates/* | Updates theme references to use Material-UI palette instead of Peak themes |
| ui/apps/pmm/src/pages/update-clients/UpdateClients.tsx | Updates Table import from percona-ui |
| ui/apps/pmm/src/pages/help-center/* | Consolidates Material-UI imports |
| ui/apps/pmm/src/main.tsx | Moves font imports to main entry point |
| ui/apps/pmm/src/hooks/* | Updates theme imports and adds eslint-disable for console statements |
| ui/apps/pmm/src/contexts/* | Updates imports and theme usage |
| ui/apps/pmm/src/components/* | Standardizes Material-UI imports across all components |
| ui/apps/pmm/src/App.tsx | Updates to use percona-ui theme provider and components |
| ui/apps/pmm/package.json | Updates to MUI v7, replaces percona packages, adds resolutions |
| ui/apps/pmm/README.md | Adds local testing instructions for percona-ui library |
| ui/apps/pmm/.eslintrc.cjs | Updates to extend from shared ESLint config |
| ui/apps/pmm-compat/src/theme.ts | Updates ColorMode type import |
| ui/.npmrc | Adds GitHub packages registry configuration |
| .github/workflows/ui.yml | Adds GitHub packages authentication |
ui/apps/pmm/src/pages/updates/change-log/code-block/CodeBlock.tsx
Outdated
Show resolved
Hide resolved
ui/apps/pmm/src/pages/updates/change-log/code-block/CodeBlock.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@fabio-silva I've opened a new pull request, #4977, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
|
|
matejkubinec
left a comment
There was a problem hiding this comment.
Just some whitespace to be removed, otherwise good :)
PMM-14690