Skip to content

Comments

PMM-14690 integrate percona UI lib#4926

Open
fabio-silva wants to merge 34 commits intov3from
PMM-14690-integrate-percona-ui-lib
Open

PMM-14690 integrate percona UI lib#4926
fabio-silva wants to merge 34 commits intov3from
PMM-14690-integrate-percona-ui-lib

Conversation

@fabio-silva
Copy link
Contributor

@fabio-silva fabio-silva commented Jan 14, 2026

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.83%. Comparing base (b659779) to head (7e88339).

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #4926      +/-   ##
==========================================
- Coverage   45.85%   45.83%   -0.02%     
==========================================
  Files         367      367              
  Lines       38531    38531              
==========================================
- Hits        17669    17662       -7     
- Misses      19163    19170       +7     
  Partials     1699     1699              
Flag Coverage Δ
admin 17.82% <ø> (ø)
agent 53.43% <ø> (-0.10%) ⬇️
managed 46.45% <ø> (+<0.01%) ⬆️
vmproxy 72.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabio-silva fabio-silva marked this pull request as ready for review January 28, 2026 18:51
@fabio-silva fabio-silva requested review from a team as code owners January 28, 2026 18:51
@fabio-silva fabio-silva requested review from YashSartanpara1, dmitri-saricev-3pillargloball, idoqo and maxkondr and removed request for a team January 28, 2026 18:51
@fabio-silva fabio-silva requested review from Copilot and matejkubinec and removed request for idoqo and maxkondr January 28, 2026 18:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates the Percona UI library (@percona/percona-ui) into PMM, replacing the previous internal theme implementation and UI component organization. The integration consolidates theme definitions, updates Material-UI imports, and removes deprecated custom theme code.

Changes:

  • Replaces @percona/design and @percona/ui-lib packages with the unified @percona/percona-ui package
  • Removes internal Peak Design System theme definitions in favor of the external library's implementation
  • Updates TypeScript configuration to use local settings instead of external package configurations
  • Standardizes Material-UI component imports across the codebase

Reviewed changes

Copilot reviewed 62 out of 63 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
ui/tsconfig.json Updates to reference local shared TypeScript configuration
ui/packages/shared/tsconfig.json Expands inline TypeScript compiler options, removing external package dependency
ui/packages/shared/src/types.ts Changes ColorMode type to use Material-UI's PaletteMode
ui/packages/shared/src/theme/peak-ds.ts Removes entire Peak Design System theme definitions (408 lines)
ui/packages/shared/src/theme/index.ts Removes theme exports
ui/packages/shared/src/index.ts Removes theme re-export
ui/packages/shared/package.json Removes @percona/tsconfig dependency
ui/packages/shared/.eslintrc.cjs Expands ESLint configuration inline
ui/package.json Adds workspaces nohoist configuration for react-router-dom
ui/apps/pmm/vitest.config.ts Creates new test configuration with React deduplication and percona-ui inline support
ui/apps/pmm/vite.config.ts Adds React deduplication, optimizeDeps force, and watch configuration for linked packages
ui/apps/pmm/src/utils/testWrapper.tsx Updates to import theme from percona-ui
ui/apps/pmm/src/types/util.types.ts Standardizes SvgIcon import
ui/apps/pmm/src/types/navigation.types.ts Standardizes ChipProps import
ui/apps/pmm/src/themes/PmmTheme.tsx Removes entire PMM theme implementation (255 lines)
ui/apps/pmm/src/pages/updates/* Updates theme references to use Material-UI palette instead of Peak themes
ui/apps/pmm/src/pages/update-clients/UpdateClients.tsx Updates Table import from percona-ui
ui/apps/pmm/src/pages/help-center/* Consolidates Material-UI imports
ui/apps/pmm/src/main.tsx Moves font imports to main entry point
ui/apps/pmm/src/hooks/* Updates theme imports and adds eslint-disable for console statements
ui/apps/pmm/src/contexts/* Updates imports and theme usage
ui/apps/pmm/src/components/* Standardizes Material-UI imports across all components
ui/apps/pmm/src/App.tsx Updates to use percona-ui theme provider and components
ui/apps/pmm/package.json Updates to MUI v7, replaces percona packages, adds resolutions
ui/apps/pmm/README.md Adds local testing instructions for percona-ui library
ui/apps/pmm/.eslintrc.cjs Updates to extend from shared ESLint config
ui/apps/pmm-compat/src/theme.ts Updates ColorMode type import
ui/.npmrc Adds GitHub packages registry configuration
.github/workflows/ui.yml Adds GitHub packages authentication

fabio-silva and others added 3 commits January 28, 2026 19:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Jan 28, 2026

@fabio-silva I've opened a new pull request, #4977, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@it-percona-cla
Copy link
Contributor

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fabio-silva
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@matejkubinec matejkubinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some whitespace to be removed, otherwise good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants