PMM-14566 Skip empty fields in QAN response (PMM2 behaviour).#5021
Open
JiriCtvrtka wants to merge 4 commits intov3from
Open
PMM-14566 Skip empty fields in QAN response (PMM2 behaviour).#5021JiriCtvrtka wants to merge 4 commits intov3from
JiriCtvrtka wants to merge 4 commits intov3from
Conversation
JiriCtvrtka
commented
Feb 11, 2026
| MarshalOptions: protojson.MarshalOptions{ //nolint:exhaustivestruct | ||
| UseEnumNumbers: false, | ||
| EmitUnpopulated: true, | ||
| EmitUnpopulated: false, // PMM-14566 |
Contributor
Author
There was a problem hiding this comment.
PMM2 has EmitUnpopulated: false, with PMM3 it was changed to true.
Because of PMM-14566 and much lower response size we should keep behaviour from PMM 2.
JiriCtvrtka
requested review from
ademidoff and
maxkondr
and removed request for
a team
ademidoff
approved these changes
Feb 12, 2026
maxkondr
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14566
FB: Percona-Lab/pmm-submodules#4221