Conversation
The tests flakiness was caused by several reasons: - tests didn't wait while Grafana inside PMM Server is fully up and running after all initializations and migrations - not all tests were idempotent - api-tests/server/settings tests update PMM Server configuration that triggers Grafana restart -> other tests fail while Grafata is unavailable. Improvements: - Added test for RTA Mongodb Agent. - api-tests/server/settings has been separated from the rest of tests and is running at the end to avoid impact on the rest of tests - Make almost all tests running in parallel -> speedup test execution - Reworked Makefile - now there are targets to prepare and run tests. reworked Makefile
maxkondr
requested review from
JiriCtvrtka and
ademidoff
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5299 +/- ##
==========================================
- Coverage 42.14% 42.13% -0.01%
==========================================
Files 410 410
Lines 41992 41992
==========================================
- Hits 17696 17695 -1
- Misses 22512 22514 +2
+ Partials 1784 1783 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
reviewed
Apr 28, 2026
Member
|
@maxkondr The trouble is that the snooze tests are not passing. PTAL |
Contributor
Author
Now passing |
JiriCtvrtka
reviewed
May 1, 2026
Comment on lines
-230
to
-231
| require.NotEmpty(t, genericNodeID) | ||
| defer pmmapitests.RemoveNodes(t, genericNodeID) |
Contributor
There was a problem hiding this comment.
Are we sure we don’t need this check anymore? Here and other places.
JiriCtvrtka
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-7
Link to the Feature Build: Percona-Lab/pmm-submodules#4329
The tests flakiness was caused by several reasons:
Improvements:
Closes #2342.