Skip to content

PMM-14594 Backup compatibility fix. - #5395

Merged
ademidoff merged 39 commits into
mainfrom
PMM-14594-backup-compatibility
Jun 25, 2026
Merged

PMM-14594 Backup compatibility fix.#5395
ademidoff merged 39 commits into
mainfrom
PMM-14594-backup-compatibility

Conversation

@JiriCtvrtka

@JiriCtvrtka JiriCtvrtka commented May 21, 2026

Copy link
Copy Markdown
Contributor

PMM-14594

FB: Percona-Lab/pmm-submodules#4368

  • Fixed MySQL backup compatibility checks for MySQL 8.4 LTS by allowing Percona XtraBackup 8.4.x with MySQL 8.4.x.
  • Kept existing MySQL 8.0.22+ behavior: XtraBackup 8.0.x must have the same or newer core version and stay below 8.1.
  • Improved incompatible XtraBackup error messages so they explain which XtraBackup family/version should be used.
  • Added unit coverage for MySQL 8.4 positive/negative compatibility cases and equivalence tests to ensure the refactor preserves existing behavior.
  • Updated MySQL backup prerequisites documentation with the MySQL-to-XtraBackup compatibility matrix.

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.56%. Comparing base (8cef340) to head (4077320).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5395      +/-   ##
==========================================
+ Coverage   43.55%   43.56%   +0.01%     
==========================================
  Files         414      414              
  Lines       42985    43058      +73     
==========================================
+ Hits        18721    18759      +38     
- Misses      22388    22419      +31     
- Partials     1876     1880       +4     
Flag Coverage Δ
admin 34.78% <ø> (ø)
agent 48.80% <ø> (-0.34%) ⬇️
managed 43.02% <100.00%> (+0.15%) ⬆️
vmproxy 72.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JiriCtvrtka

Copy link
Copy Markdown
Contributor Author

@copilot review

…ide caution admonition

Agent-Logs-Url: https://github.com/percona/pmm/sessions/26f00a58-ad66-4a7b-8e9a-573f1cef3d41

Co-authored-by: JiriCtvrtka <62988319+JiriCtvrtka@users.noreply.github.com>
@it-percona-cla

it-percona-cla commented May 21, 2026

Copy link
Copy Markdown
Contributor

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ catalinaadam
✅ JiriCtvrtka
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI commented May 21, 2026

Copy link
Copy Markdown
Contributor

@copilot review

Reviewed the changes. The core logic looks correct:

  • maxAlignedXtrabackupVersion (9.0) properly replaced with bounded version constants (mysql81Version, mysql84Version, mysql85Version)
  • Compatibility matrix entries for pre-8.0.22 MySQL now correctly use 8.1.0 as the XtraBackup upper bound instead of 9.0
  • MySQL 8.4.x → XtraBackup 8.4.x mapping is correctly implemented
  • Error messages are now actionable with specific guidance per version range
  • Tests cover all new paths including MySQL 8.4 + XtraBackup 8.4 compatibility

One documentation formatting issue was found and fixed in commit 1d0cd0e: the version compatibility table and the XtraBackup 8.4 note were placed outside the caution admonition block. They are now properly indented inside it.

@JiriCtvrtka
JiriCtvrtka marked this pull request as ready for review May 22, 2026 11:43
@JiriCtvrtka
JiriCtvrtka requested review from a team as code owners May 22, 2026 11:43
@JiriCtvrtka
JiriCtvrtka requested review from 4nte, ademidoff and maxkondr and removed request for a team May 22, 2026 11:43
Comment thread managed/services/backup/compatibility_helpers.go Outdated
@JiriCtvrtka
JiriCtvrtka requested a review from maxkondr May 25, 2026 12:07
Comment thread managed/services/backup/compatibility_helpers.go
@JiriCtvrtka

Copy link
Copy Markdown
Contributor Author

@copilot review and verify if #5395 (comment) is addressed.

@JiriCtvrtka
JiriCtvrtka enabled auto-merge (squash) June 24, 2026 08:42
@JiriCtvrtka
JiriCtvrtka disabled auto-merge June 24, 2026 08:44
@JiriCtvrtka
JiriCtvrtka enabled auto-merge (squash) June 25, 2026 06:45
@catalinaadam
catalinaadam temporarily deployed to PMM-14594-backup-compatibility - pmm-doc-3.8.0 PR #5395 June 25, 2026 06:46 — with Render Destroyed
@ademidoff
ademidoff temporarily deployed to PMM-14594-backup-compatibility - pmm-doc-3 PR #5395 June 25, 2026 06:46 — with Render Destroyed
@ademidoff
ademidoff disabled auto-merge June 25, 2026 06:56
@ademidoff
ademidoff merged commit 989212b into main Jun 25, 2026
28 of 30 checks passed
@ademidoff
ademidoff deleted the PMM-14594-backup-compatibility branch June 25, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants