Skip to content

PMM-14908: exclude async replicas from MySQL GR delay panels#5664

Open
mattiasimonato wants to merge 4 commits into
mainfrom
PMM-14908-filter-async-from-gr-dashboard
Open

PMM-14908: exclude async replicas from MySQL GR delay panels#5664
mattiasimonato wants to merge 4 commits into
mainfrom
PMM-14908-filter-async-from-gr-dashboard

Conversation

@mattiasimonato

@mattiasimonato mattiasimonato commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Ticket number: PMM-14908

Feature build: SUBMODULES-5664

  • Replication Delay Details panels were showing async replica nodes because worker lag metrics exist for both GR and async
  • Intersect those queries with GR member_info (including MySQL 5 variant and $replication_set) so only GR members appear

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.02%. Comparing base (31318c7) to head (effb597).
⚠️ Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5664      +/-   ##
==========================================
- Coverage   43.59%   37.02%   -6.57%     
==========================================
  Files         415      215     -200     
  Lines       43134     7160   -35974     
  Branches        0      591     +591     
==========================================
- Hits        18804     2651   -16153     
+ Misses      22454     4371   -18083     
+ Partials     1876      138    -1738     
Flag Coverage Δ
admin 34.94% <ø> (+0.15%) ⬆️
agent ?
managed ?
unittests 41.29% <ø> (?)
vmproxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MySQL Group Replication Summary Grafana dashboard to ensure the “Replication Delay Details” panels only display Group Replication (GR) members, excluding async replicas that may expose similarly named worker-lag metrics.

Changes:

  • Updated five PromQL expressions to intersect worker lag/latency metrics with GR member_info metrics (including the MySQL 5 variant) using and on(service_name).
  • Ensures panels only show series for services that are confirmed GR members under the selected $replication_set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mattiasimonato
mattiasimonato marked this pull request as ready for review July 20, 2026 07:05
@mattiasimonato
mattiasimonato requested review from a team and Nailya as code owners July 20, 2026 07:05
@mattiasimonato
mattiasimonato requested review from fabio-silva, matejkubinec and michaelcoburn and removed request for a team July 20, 2026 07:05

@michaelcoburn michaelcoburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants