PMM-15091: stop double-counting RAID md devices in Disk Details#5675
Open
mattiasimonato wants to merge 4 commits into
Open
PMM-15091: stop double-counting RAID md devices in Disk Details#5675mattiasimonato wants to merge 4 commits into
mattiasimonato wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Disk Details Grafana dashboard variable query to avoid double-counting I/O when both Linux software RAID (md*) devices and their member disks are present, improving the accuracy of “Total Performance” panels that aggregate over $device.
Changes:
- Exclude
md*devices from the$devicetemplate variable query (in addition to existingdm-*exclusion) to prevent RAID array + member disk double aggregation. - Apply the same exclusion to both the variable
definitionandqueryfields for consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5675 +/- ##
==========================================
- Coverage 43.59% 37.02% -6.57%
==========================================
Files 415 215 -200
Lines 43134 7160 -35974
Branches 0 585 +585
==========================================
- Hits 18804 2651 -16153
+ Misses 22454 4314 -18140
+ Partials 1876 195 -1681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Open
1 task
mattiasimonato
marked this pull request as ready for review
July 21, 2026 10:16
mattiasimonato
requested review from
fabio-silva and
matejkubinec
and removed request for
a team
July 21, 2026 10:16
fabio-silva
approved these changes
Jul 21, 2026
matejkubinec
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number: PMM-15091
Feature build: SUBMODULES-4488
Total Performance on Disk Details sums metrics over
$device. That variable already skipped LVM devices (dm-*), but still included both the RAID array (md0) and its member disks (sda,sdb). Summing those together counted the same I/O twice, so panels showed about 2× real IOPS/throughput.Fix: exclude RAID arrays in the
$devicequery withdevice!~"dm-.+|md.+", same idea as LVM. Panels keep using$device, so Total Performance stops double-counting. Usedmd.+(notmd[0-9].+) so names likemd0match.