PMM-15360: Add the OpenManager settings flag - #5851
Merged
Merged
Conversation
This was referenced Aug 28, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PMM-15299-open-manager #5851 +/- ##
=========================================================
Coverage ? 46.66%
=========================================================
Files ? 431
Lines ? 45640
Branches ? 0
=========================================================
Hits ? 21296
Misses ? 22267
Partials ? 2077
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
plebioda
force-pushed
the
PMM-15360-om-switch-flag
branch
2 times, most recently
from
August 31, 2026 06:51
db6d354 to
dd26130
Compare
Adds Settings.OpenManager.Enabled to pmm-managed and an Advanced Settings toggle for it, default off like every other technical-preview flag (Azure Discover, Access Control). PMM_ENABLE_OM seeds it the same way PMM_ENABLE_NOMAD/PMM_ENABLE_AZURE_DISCOVER do, and reuses validateChangeSettingsRequest's existing env-var-wins precedence check rather than adding a new mechanism. This only exposes and stores the flag; nothing reads it yet to gate OpenManager's own behavior. That's the follow-up PR, once this and PMM-15326-om-backend / PMM-15326-om-ui-nav are all available to stack on. Signed-off-by: Pawel Lebioda <pawel.lebioda@percona.com>
…abled make gen does more than buf generate -- it also regenerates the swagger/OpenAPI JSON (api/server/v1/json/v1.json, the merged api/swagger/swagger*.json) and the generated JSON API client (api/server/v1/json/client/server_service/*.go) from the same proto. The earlier commit only ran buf generate directly and hand-curated its output against unrelated toolchain drift elsewhere in api/, which missed these -- they're make gen's job, not buf generate's. Also picks up the same protoc-gen-go import-grouping drift on server.pb.go/server.pb.validate.go that affects unrelated proto packages across the tree; taking make gen's own output here (rather my earlier hand-curated one) is what actually matches what CI's own gen step produces, so this and CI won't disagree again. The generated client's field names are OmEnabled/EnableOm here, matching this branch's own api/Makefile: --additional-initialism=om was added to the swagger client generator's flag list by PMM-15326-om-api, but that commit hasn't reached this branch's base (PMM-15299-open-manager) yet, so "om" isn't a registered initialism here and go-swagger capitalizes it as an ordinary word. Branches that already have that flag (PMM-15326-om-backend and its descendants) will correctly want OMEnabled/EnableOM instead -- each PR's generated code has to match its own base's Makefile, not a single "right" answer across the stack. Found because CI's "make gen; git diff --exit-code" check failed on this exact mismatch, on all three of this ticket's PRs. Signed-off-by: Pawel Lebioda <pawel.lebioda@percona.com>
plebioda
force-pushed
the
PMM-15360-om-switch-flag
branch
from
August 31, 2026 08:18
dd26130 to
68eea37
Compare
plebioda
marked this pull request as ready for review
August 31, 2026 10:25
plebioda
requested review from
4nte,
ademidoff and
matejkubinec
and removed request for
a team
August 31, 2026 10:25
plebioda
added a commit
that referenced
this pull request
Aug 31, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
Settings.OpenManager.Enabledto pmm-managed and an Advanced Settings toggle for it, default off like every other technical-preview flag (Azure Discover, Access Control).PMM_ENABLE_OMseeds it the same wayPMM_ENABLE_NOMAD/PMM_ENABLE_AZURE_DISCOVERdo, and reusesvalidateChangeSettingsRequest's existing env-var-wins precedence check rather than adding a new mechanism.This only exposes and stores the flag; nothing reads it yet to gate OpenManager's own behavior. That's the follow-up PR (#TBD), once this and PMM-15326-om-backend / PMM-15326-om-ui-nav are all available to stack on.
Ticket: PMM-15360
First of three PRs for PMM-15360
PMM-15326-om-backend(PMM-15326: Implement the OM service in pmm-managed #5816)PMM-15326-om-ui-nav(PMM-15326: Mount OM in the PMM app and its navigation #5818)PRs 2 and 3 both merge this branch in (rather than depending on the non-PR
PMM-15326-om-integrationbranch), so their diffs will show this PR's changes inline until it merges.Feature build: N/A on its own — this only adds a setting nothing reads yet.