PMM-15281: Gate SEP's presence in the PMM UI on availability - #5876
Merged
Conversation
peter-o-addo
requested review from
fabio-silva and
matejkubinec
and removed request for
a team
September 2, 2026 09:29
Contributor
peter-o-addo
marked this pull request as draft
September 2, 2026 09:40
fabio-silva
approved these changes
Sep 2, 2026
peter-o-addo
marked this pull request as ready for review
September 2, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number: PMM-15281
What
Gate SEP navigation and routes on
settings.sepEnabled(the UI surface ofPMM_ENABLE_SEP). When the integration is off, SEP entries stay out of the sidebar and direct navigation to a SEP route shows an explicit “not enabled” state instead of mounting the auth gate or firing SEP API requests.SEP remains available to every signed-in user when enabled; write controls stay per-control via
canMutate(PMM-15358), not behindisPMMAdmin.Changes
sepEnabledtoReadonlySettingsand default it tofalsefor anonymous users / test stubs!user.isAnonymous && settings?.sepEnabledSepPageon settings: wait while loading/settingsis null, then show unavailable whensepEnabledis falseSepPagetestsNotes
sep_enabledfrom/v1/server/settingsand/v1/server/settings/readonlyonce the backend exposes it; until then the UI treats SEP as disabled (safe default)./healthprobe — gating is env-var / settings only, matching the updated ticket direction.If this PR adds, removes or alters one or more API endpoints, please review and update the relevant API documentation as well:
If this PR is related to other PRs, contributions, or ongoing work in this or other repositories, please reference them here:
PMM_ENABLE_SEPassep_enabledon Settings / ReadOnlySettingsPMM_ENABLE_SEP,/sep/mount)