Skip to content

PMM-15281: Gate SEP's presence in the PMM UI on availability - #5876

Merged
yyyyyyyan merged 6 commits into
PMM-15205-sep-fbfrom
PMM-15281-sep-availability
Sep 2, 2026
Merged

PMM-15281: Gate SEP's presence in the PMM UI on availability#5876
yyyyyyyan merged 6 commits into
PMM-15205-sep-fbfrom
PMM-15281-sep-availability

Conversation

@peter-o-addo

@peter-o-addo peter-o-addo commented Sep 2, 2026

Copy link
Copy Markdown

Ticket number: PMM-15281

What

Gate SEP navigation and routes on settings.sepEnabled (the UI surface of PMM_ENABLE_SEP). When the integration is off, SEP entries stay out of the sidebar and direct navigation to a SEP route shows an explicit “not enabled” state instead of mounting the auth gate or firing SEP API requests.

SEP remains available to every signed-in user when enabled; write controls stay per-control via canMutate (PMM-15358), not behind isPMMAdmin.

Changes

  • Add sepEnabled to ReadonlySettings and default it to false for anonymous users / test stubs
  • Push SEP Management nav only when !user.isAnonymous && settings?.sepEnabled
  • Gate SepPage on settings: wait while loading/settings is null, then show unavailable when sepEnabled is false
  • Cover enabled, disabled, and loading paths in nav and SepPage tests

Notes

  • Frontend-only. Consumes sep_enabled from /v1/server/settings and /v1/server/settings/readonly once the backend exposes it; until then the UI treats SEP as disabled (safe default).
  • No /health probe — gating is env-var / settings only, matching the updated ticket direction.

If this PR adds, removes or alters one or more API endpoints, please review and update the relevant API documentation as well:

  • API Docs updated

If this PR is related to other PRs, contributions, or ongoing work in this or other repositories, please reference them here:

@peter-o-addo
peter-o-addo requested a review from a team as a code owner September 2, 2026 09:29
@peter-o-addo
peter-o-addo requested review from fabio-silva and matejkubinec and removed request for a team September 2, 2026 09:29
@it-percona-cla

it-percona-cla commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

CLA assistant check
All committers have signed the CLA.

@peter-o-addo
peter-o-addo requested a review from nachodd September 2, 2026 09:34
@peter-o-addo
peter-o-addo marked this pull request as draft September 2, 2026 09:40
@peter-o-addo
peter-o-addo marked this pull request as ready for review September 2, 2026 16:31
@yyyyyyyan
yyyyyyyan merged commit 71d0d27 into PMM-15205-sep-fb Sep 2, 2026
7 checks passed
@yyyyyyyan
yyyyyyyan deleted the PMM-15281-sep-availability branch September 2, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants