-
Notifications
You must be signed in to change notification settings - Fork 11
Added SQL testcases for the following Bugs #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PG-1495 CLUSTER Command Decrypts Encrypted Table in PostgreSQL with TDE Enabled PG-1491 pg_tde_is_encrypted() is broken for partitioned tables Following new tescases added: cluster.sql partition_table.sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohitj1988 The reason your tests are failing is because you used to global provider which makes writing tests trickier. The easy solution is the use a database provider.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (76.09%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #207 +/- ##
==================================================
Coverage 76.09% 76.09%
==================================================
Files 23 23
Lines 2523 2523
Branches 394 394
==================================================
Hits 1920 1920
Misses 526 526
Partials 77 77
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good but I had two suggestions for improvement that you could act on or ignore as you wish.
PG-1491 pg_tde_is_encrypted() is broken for partitioned tables
Following new tescases added:
partition_table.sql