Skip to content

Added SQL testcases for the following Bugs #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 18, 2025

Conversation

mohitj1988
Copy link
Collaborator

@mohitj1988 mohitj1988 commented Apr 11, 2025

PG-1491 pg_tde_is_encrypted() is broken for partitioned tables

Following new tescases added:
partition_table.sql

PG-1495 CLUSTER Command Decrypts Encrypted Table in PostgreSQL with TDE Enabled
PG-1491 pg_tde_is_encrypted() is broken for partitioned tables

Following new tescases added:
cluster.sql
partition_table.sql
@it-percona-cla
Copy link

it-percona-cla commented Apr 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@jeltz jeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohitj1988 The reason your tests are failing is because you used to global provider which makes writing tests trickier. The easy solution is the use a database provider.

@mohitj1988 mohitj1988 requested a review from jeltz April 16, 2025 04:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.09%. Comparing base (3b6d3d4) to head (b34711e).

❌ Your project status has failed because the head coverage (76.09%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #207   +/-   ##
==================================================
  Coverage              76.09%   76.09%           
==================================================
  Files                     23       23           
  Lines                   2523     2523           
  Branches                 394      394           
==================================================
  Hits                    1920     1920           
  Misses                   526      526           
  Partials                  77       77           
Components Coverage Δ
access 71.52% <ø> (ø)
catalog 86.06% <ø> (ø)
common 92.50% <ø> (ø)
encryption 71.90% <ø> (ø)
keyring 69.87% <ø> (ø)
src 52.96% <ø> (ø)
smgr 96.77% <ø> (ø)
transam 95.91% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jeltz jeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but I had two suggestions for improvement that you could act on or ignore as you wish.

@dAdAbird dAdAbird merged commit eb8b307 into percona:TDE_REL_17_STABLE Apr 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants