Only extract typedefs from our object file #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the PostgreSQL repo already contains a script extracting typedefs from object files let's use it.
The reason to do this is that the old approach actually created an unnecessary diff against upstream where they had forgot SinglePartitionSpec in typedefs.list. Additionally add the new struct for our SMGR patch to the list.
dutow
reviewed
Apr 11, 2025
| @@ -1607,6 +1607,7 @@ ManyTestResourceKind | |||
| Material | |||
| MaterialPath | |||
| MaterialState | |||
| MdSMgrRelationData | |||
There was a problem hiding this comment.
We also have XLogSmgr? And maybe nothing else defined in the "main" sources, but with this we have to be more careful.
There was a problem hiding this comment.
Oh, that is a good point. That makes the script kinda stupid as of my rewrite of it since it cares about which typedefs we used in pg_tde.so which MdSMgrRelationData is not while XLogSmgr is. Hmm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason to do this is that the old approach actually created an
unnecessary diff against upstream where they had forgot
SinglePartitionSpecin typedefs.list. Additionally add the new structfor our SMGR patch to the list.
Also make sure to use
src/tools/find_typedeffor this instead of using an own very similar script.