XLog signed info when creating a Principal Key #209
Merged
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we XLogged an unsigned PrincipalKey info when creating the key. Which leads to: 1. In case of crash recovery, the redo would rewrite a map_ file with an empty sign info. And the server would later fail to start with "Failed to verify principal key header..." 2. Replicas would create a _map file with an empty sign info. Which in turn leads to a fail on restart.
|
Hi @dAdAbird - Before you merge this PR, I tested it and found that for rotated WAL key, the problem still exists I got this error while testing it 2025-04-11 16:54:13.941 GMT [666644] FATAL: Failed to verify principal key header for key principal_key_test24886, incorrect principal key or corrupted key file |
jeltz
requested changes
Apr 14, 2025
dAdAbird
force-pushed
the
signed_key_recovery
branch
from
e8905e1 to
90014f9
Compare
dAdAbird
changed the title
|
@jeltz I removed the 2nd commit from the PR |
|
@mohitj1988 I'll fix it in the separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we XLogged an unsigned PrincipalKey info when
creating the key. Which leads to:
In case of crash recovery, the redo would rewrite a map_ file with
an empty sign info. And the server would later fail to start with
"Failed to verify principal key header..."
Replicas would create a _map file with an empty sign info. Which in
turn leads to a fail on restart.
For PG-1539