Skip to content

Conversation

@patrickbirch
Copy link
Collaborator

…enerated even when user filter is set to {"filter": {"log": false}}

new file:   docs/write-audit-log-filter-definitions.md
modified:   mkdocs-base.yml

@it-percona it-percona temporarily deployed to ps-10161 - percona-server-docs-8.0 PR #569 September 18, 2025 17:16 — with Render Destroyed
@it-percona it-percona requested a deployment to ps-10161 - percona-server-docs-8.0 PR #569 September 18, 2025 17:26 — with Render Abandoned
@render render bot requested a deployment to ps-10161 - percona-server-docs-8.0 PR #569 September 18, 2025 17:26 Abandoned
@svetasmirnova
Copy link
Collaborator

Generally looks good but I left few comments. Please check and resolve them.

Comment on lines 406 to 455
{
"filter": {
"class": {
"name": "general",
"event": [
{
"name": "status",
"print": {
"field": {
"name": "general_query.str",
"print": false,
"replace": {
"function": {
"name": "query_digest"
}
}
}
}
}
]
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filter is giving an error in PS8.4.6-6

SELECT audit_log_filter_set_filter('log_query_digest', '
{
  "filter": {
    "class": {
      "name": "general",
      "event": [
        {
          "name": "status",
          "print": {
            "field": {
              "name": "general_query.str",
              "print": false,
              "replace": {
                "function": {
                  "name": "query_digest"
                }
              }
            }
          }
        }
      ]
    }
  }
}');

2025-12-02T11:47:36.802139Z 192 [ERROR] [MY-048083] [Server] Component audit_log_filter reported: 'Event field 'general_query.str' cannot be replaced'
2025-12-02T11:47:36.802301Z 192 [ERROR] [MY-048108] [Server] Component audit_log_filter reported: 'Wrong JSON filter 'log_query_digest' format, bad format for 'field' action'
2025-12-02T11:47:36.802350Z 192 [ERROR] [MY-048111] [Server] Component audit_log_filter reported: 'Wrong argument: incorrect rule definition ' {   "filter": {     "class": {       "name": "general",       "event": [         {           "name": "status",           "print": {             "field": {               "name": "general_query.str",               "print": false,               "replace": {                 "function": {                   "name": "query_digest"                 }               }             }           }         }       ]     }   } }''

…enerated even when user filter is set to {"filter": {"log": false}}

	new file:   docs/write-audit-log-filter-definitions.md
	modified:   mkdocs-base.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Something that should not be merged right now

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants