-
Notifications
You must be signed in to change notification settings - Fork 29
PS-10161 [DOCS] - pre_authenticate and general log events are still g… #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patrickbirch
wants to merge
1
commit into
8.0
Choose a base branch
from
ps-10161
base: 8.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9493cd9 to
a1caba0
Compare
alina-derkach-oaza
approved these changes
Sep 18, 2025
a1caba0 to
b6839c0
Compare
b6839c0 to
d43d3f8
Compare
d43d3f8 to
d52cb9e
Compare
d52cb9e to
b901561
Compare
b901561 to
a69dae9
Compare
a69dae9 to
258ccff
Compare
258ccff to
b7cb38a
Compare
b7cb38a to
d1d4b92
Compare
svetasmirnova
suggested changes
Sep 23, 2025
Collaborator
|
Generally looks good but I left few comments. Please check and resolve them. |
d1d4b92 to
2a04eb4
Compare
mchawla16
reviewed
Nov 28, 2025
mchawla16
reviewed
Dec 2, 2025
mchawla16
reviewed
Dec 2, 2025
Comment on lines
406
to
455
| { | ||
| "filter": { | ||
| "class": { | ||
| "name": "general", | ||
| "event": [ | ||
| { | ||
| "name": "status", | ||
| "print": { | ||
| "field": { | ||
| "name": "general_query.str", | ||
| "print": false, | ||
| "replace": { | ||
| "function": { | ||
| "name": "query_digest" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filter is giving an error in PS8.4.6-6
SELECT audit_log_filter_set_filter('log_query_digest', '
{
"filter": {
"class": {
"name": "general",
"event": [
{
"name": "status",
"print": {
"field": {
"name": "general_query.str",
"print": false,
"replace": {
"function": {
"name": "query_digest"
}
}
}
}
}
]
}
}
}');
2025-12-02T11:47:36.802139Z 192 [ERROR] [MY-048083] [Server] Component audit_log_filter reported: 'Event field 'general_query.str' cannot be replaced'
2025-12-02T11:47:36.802301Z 192 [ERROR] [MY-048108] [Server] Component audit_log_filter reported: 'Wrong JSON filter 'log_query_digest' format, bad format for 'field' action'
2025-12-02T11:47:36.802350Z 192 [ERROR] [MY-048111] [Server] Component audit_log_filter reported: 'Wrong argument: incorrect rule definition ' { "filter": { "class": { "name": "general", "event": [ { "name": "status", "print": { "field": { "name": "general_query.str", "print": false, "replace": { "function": { "name": "query_digest" } } } } } ] } } }''
mchawla16
reviewed
Dec 2, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
mchawla16
reviewed
Dec 3, 2025
d427859 to
595e459
Compare
595e459 to
488f4f9
Compare
…enerated even when user filter is set to {"filter": {"log": false}}
new file: docs/write-audit-log-filter-definitions.md
modified: mkdocs-base.yml
488f4f9 to
03dc801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enerated even when user filter is set to {"filter": {"log": false}}