feat: Adding to Sebastian Agudelo in /about #245
Conversation
|
5 lines of code were never so painful xd |
|
@xergioalex do you now what is failing the check of pr SIZE, of @Mega-Barto ? I think that him changes are ok! |
|
I think there’s a bug in our PR calculate size step when the PR branch comes from an external repository. We’re trying to read the source branch from the origin repository, but it’s not present because the branch belongs to an external repository. |
|
Don't close I will fix the PR checker workflow |
stivencardona
force-pushed
the
adding_agudelo
branch
2 times, most recently
from
8ecbb26 to
cf0ab2b
Compare
| @@ -72,6 +72,11 @@ const team = [ | |||
| name: 'Sergio Florez', | |||
| socialLink: 'https://www.linkedin.com/in/xergioalex/', | |||
| }, | |||
| { | |||
| name: 'Sebastián Agudelo Morales', | |||
| image: 'https://i.imgur.com/2wzs36v.jpeg', | |||
There was a problem hiding this comment.
@Mega-Barto can you upload the image to the assets/image/people/team directory? just to avoid call an external source
There was a problem hiding this comment.
Please resolve this, and we can merge your changes
stivencardona
force-pushed
the
adding_agudelo
branch
from
cf0ab2b to
f3e42fc
Compare
|
@Mega-Barto Please fix the pending change or the PR will be declined. |
After a several mistakes (thanks @stivencardona), I added the data of Sebastian Agudelo in /about. This has been propertly tested.