Fix session memory injection logic and prevent duplicate memory entries#34
Open
yishangupenn wants to merge 3 commits into
Open
Fix session memory injection logic and prevent duplicate memory entries#34yishangupenn wants to merge 3 commits into
yishangupenn wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes and simplifies session memory handling in the 'examples/agents_sdk/context_personalization.ipynb' notebook.
It addresses two related issues:
The changes ensure that session memory is injected consistently when available, and that identical session notes are updated instead of duplicated.
Motivation
In tool-heavy and iterative conversations, recent session context is often required across multiple turns, not only after a trim event. The previous trim-gated injection could lead to loss of short-term context in these cases.
Additionally, session memory notes were previously append-only, allowing identical notes to accumulate over time. This PR introduces a simple deduplication mechanism to keep session memory concise and up to date.
These changes improve:
Changes Included
No changes were made to global or long-term memory behavior.
Notes
For new content
When contributing new content, read through our contribution guidelines, and mark the following action items as completed:
We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.