Skip to content

fix: no pcp-pmda-openmetrics on EL7 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/pcp/setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
vars:
pcp_pmie_endpoint: https://example.com/webhook
pcp_pmlogger_interval: 10
# NOTE: No openmetrics on EL7
pcp_optional_agents: [dm, nfsclient, openmetrics]
pcp_explicit_labels:
environment: production
1 change: 1 addition & 0 deletions roles/pcp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ Basic PCP setup with monitoring suited for a single host.
- role: performancecopilot.metrics.pcp
vars:
pcp_pmlogger_interval: 10
# NOTE: No openmetrics on EL7
pcp_optional_agents: [dm, nfsclient, openmetrics]
pcp_explicit_labels:
environment: production
Expand Down
2 changes: 2 additions & 0 deletions roles/spark/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
when:
- spark_metrics_provider == 'pcp'
- spark_metrics_agent | d(false) | bool
- "'pcp-pmda-openmetrics' in __spark_packages_pcp"

- name: Ensure PCP OpenMetrics agent is enabled with Spark endpoint
file:
Expand All @@ -65,6 +66,7 @@
when:
- spark_metrics_provider == 'pcp'
- spark_metrics_agent | d(false) | bool
- "'pcp-pmda-openmetrics' in __spark_packages_pcp"

- name: Ensure correct service path for ostree systems
when:
Expand Down
2 changes: 2 additions & 0 deletions roles/spark/vars/CentOS_7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
__spark_packages_export_pcp:
- pcp-export-pcp2spark
- pcp-system-tools

__spark_packages_pcp: []
2 changes: 2 additions & 0 deletions roles/spark/vars/RedHat_7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
__spark_packages_export_pcp:
- pcp-export-pcp2spark
- pcp-system-tools

__spark_packages_pcp: []
Loading