Fix nowebgroup.c: remove return from void function #2440
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compile error in nowebgroup.c:111 where pmWebGroupDestroy (declared as void) incorrectly returns -EOPNOTSUPP. This bug was introduced in commit 5903430 (Dec 17, 2025) which added the stub but included a return statement in a void function. Fixes compilation on macOS without libuv installed, where modern Clang enforces -Wreturn-mismatch.
Contributor
|
Thanks @tallpsmith . I hit the same issue a few days back, when building manually PCP on Fedora using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation error on macOS without libuv where pmWebGroupDestroy
(declared void) incorrectly returns -EOPNOTSUPP.
Issue
Commit 5903430 added pmWebGroupDestroy stub to nowebgroup.c but
included
return -EOPNOTSUPP;in a void function, causing:Why CI Passes But Local Builds Fail
GitHub macOS runners have Node.js pre-installed, which depends on
libuv as a Homebrew dependency. This means CI builds use webgroup.c
(real implementation) instead of nowebgroup.c (stub), masking this bug.
Local macOS builds without libuv installed hit this error with modern
Clang's strict -Wreturn-mismatch enforcement.
Solution
Remove the return statement from the void stub function, matching the
pattern of other stubs in the same file (pmWebGroupDerive,
pmWebGroupFetch, etc).
Testing
Verified clean build on macOS 25.2.0 (arm64) without libuv using:
Build completes successfully (exit code 0) after this fix.