Skip to content

Commit

Permalink
✨ retrieve variable when trigger is evaluated, because variable's loc…
Browse files Browse the repository at this point in the history
…ation and even itself may be changed during workflow running.
  • Loading branch information
perillaroc committed Feb 6, 2025
1 parent 47ce8e8 commit 75dbbaa
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions takler/core/expression_ast.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@
from .event import Event
from .meter import Meter
from .parameter import Parameter
from takler.logging import get_logger

if TYPE_CHECKING:
from .node import Node


logger = get_logger(__name__)
T = TypeVar("T")


Expand Down Expand Up @@ -144,8 +146,11 @@ def value(self) -> Optional[int]:
raise NotImplementedError(f"{v} is not support")

def get_variable(self) -> Optional[Event]:
if self._node_variable is not None:
return self._node_variable
# NOTE: delete following codes to retrieve variable when trigger is evaluated,
# because variable's location and even itself may be changed during workflow running.

# if self._node_variable is not None:
# return self._node_variable

self._node_variable = self.node.get_reference_node().find_variable(self.variable_name)
return self._node_variable
Expand Down

0 comments on commit 75dbbaa

Please sign in to comment.