Persist OCAD map file in localstorage between sessions #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Update: well, it didn't take long to find a map that was too large. For now, I have added some handling for this (app works like it did before). We can think about if this is still a nice feature for smaller maps, or if it's just confusing that the map is sometime saved and sometimes not. (It is nice when developing the app though...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment with storing the last used OCAD map in local storage, so the user will not have to find the map on disk every time they return to the app.
From some quick experiments, it looks like this works, but I'm not sure if the maps are really too big to expect local storage to hold them (MDN says 5-10 MB, which seems to be close to what normal size OCAD maps are, in my experience).