Skip to content

fix: Manifest folder index loop #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
speeddragon wants to merge 1 commit into
base: edge
Choose a base branch
from
+14 −1
Open

fix: Manifest folder index loop #1076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/preloaded/arweave/dev_manifest.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ route(Key, M1, M2, Opts) ->
?event(debug_manifest, {manifest_lookup, {key, Key}, {m1, M1}, {m2, {explicit, M2}}}),
{ok, Manifest} = manifest(M1, Key, Opts),
{ok, Res} = maps:find(<<"paths">>, Manifest),
case maps:get(Key, Res, no_path_match) of
case hb_util:deep_get(Key, Res, no_path_match, Opts) of
no_path_match ->
% Support materialized view in some JavaScript frameworks.
case hb_opts:get(manifest_404, fallback, Opts) of
Expand Down Expand Up @@ -414,3 +414,16 @@ manifest_should_fallback_on_not_found_path_test_parallel() ->
<<"<title>Portal</title>">>,
Opts
).

%% @doc Manifest with index path as "folder/subfolder/subsubfolder" which points
%% to an image.
sub_folder_index_test_parallel() ->
Opts = hb_name_test_utils:manifest_opts(),
Node = hb_http_server:start_node(Opts),
hb_test_utils:assert_manifest_response(
Node,
#{<<"path">> => <<"/wAy8yNYUs_nNLi61XCgaPh0yLOrF_zYFdmiWwBS8gJ4">>},
<<"image/png">>,
<<137, 80, 78, 71, 13, 10, 26, 10>>,
Opts
).