Skip to content

Conversation

@abdbali
Copy link

@abdbali abdbali commented Feb 5, 2026

Motivation
Provide Turkish language support for the app UI and help/commands so Turkish-speaking users can use the app in their language.
Ensure the new localization is included in the project build configuration and Xcode project metadata so it is packaged with the app.
Description
Added bitchat/tr.lproj/Localizable.strings containing Turkish translations for the main UI, commands and AppInfo copy (≈95 keys).
Updated bitchat/Views/ContentView.swift to use a localized fallback for the default channel name via String(localized: "channel") and fixed self-label formatting to use string interpolation ("(displayName) (you)").
Registered the localization in the build configuration by adding bitchat/tr.lproj to project.yml resources and updated bitchat.xcodeproj/project.pbxproj to add the tr region, file references, and resource entries.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3cc5637f01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +13 to +15
// MARK: - BluetoothMeshService Class
class BluetoothMeshService: NSObject, ObservableObject, CBCentralManagerDelegate, CBPeripheralDelegate {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rename or remove duplicate BluetoothMeshService class

This file introduces a second BluetoothMeshService type in the same module, but bitchat/Services/BluetoothMeshService.swift already defines a class with that name. Because Package.swift’s executable target includes all .swift files under bitchat/, SwiftPM builds will fail with an invalid redeclaration error when compiling this commit. Consider renaming this new class or removing it from the target to avoid breaking SwiftPM builds.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant