Skip to content

Sort Feature #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murphenheim wants to merge 2 commits into
base: master
Choose a base branch
from
+281 −6
Open

Sort Feature #1124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72c44c9
sort added
d7coders May 12, 2026
989611c
bug fixes
d7coders May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
287 changes: 281 additions & 6 deletions persepolis/scripts/mainwindow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ def __init__(self, start_in_tray, persepolis_main, persepolis_setting):
# if user highlights multiple items in download_table
self.multi_items_selected = False

self.sort_desc = False
# this variable is changed to False when
# user clicks on 'hide options' button in
# side panel.
Expand Down Expand Up @@ -859,6 +860,9 @@ def __init__(self, start_in_tray, persepolis_main, persepolis_setting):
# function executes
self.download_table.itemDoubleClicked.connect(self.openFile)

# add click event on headers menu
self.download_table.horizontalHeader().sectionClicked.connect(self.downloadTableHeaderClicked)

# connecting queue_panel_show_button to showQueuePanelOptions
self.queue_panel_show_button.clicked.connect(
self.showQueuePanelOptions)
Expand Down Expand Up @@ -1028,6 +1032,9 @@ def __init__(self, start_in_tray, persepolis_main, persepolis_setting):
# check reverse_checkBox
self.reverse_checkBox.setChecked(False)

# restore sort
self.restoreLastSort()

# this method used by shutdown script for changing shutdown_notification value
def changeShutdownValue(self, value):
global shutdown_notification
Expand Down Expand Up @@ -3176,6 +3183,77 @@ def deleteSelected2(self):
global checking_flag
checking_flag = 0

# sort by clickable headers in download table
def downloadTableHeaderClicked(self, column):

self.sort_desc = not self.sort_desc

if column == 0:
self.sortByName()
elif column == 1:
self.sortByStatus()
elif column == 2:
self.sortBySize()
elif column == 3:
self.sortByDownloaded()
elif column == 4:
self.sortByPercent()
elif column == 10:
self.sortByFirstTry()
elif column == 11:
self.sortByLastTry()

def findColumnByHeaderText(self, header_text):
for col in range(self.download_table.columnCount()):
item = self.download_table.horizontalHeaderItem(col)
if item and item.text() == header_text:
return col
return -1

def resetColumnByHeaderText(self):
for col in range(self.download_table.columnCount()):
item = self.download_table.horizontalHeaderItem(col)
title = item.text().replace(" ▼","").replace(" ▲","")
item.setText(title)
return -1

def updateSortHeaderIndicator(self, active_key=None, descending=False):
self.resetColumnByHeaderText()
selected = self.findColumnByHeaderText(active_key)

header = self.download_table.horizontalHeaderItem(selected)
title = header.text()+ (' ▼' if descending else ' ▲')
header.setText(title)

# save the sort to setting to reuse it when app opens next time
self.persepolis_setting.setValue('sort/column', active_key)
self.persepolis_setting.setValue('sort/descending', self.sort_desc)

def restoreLastSort(self):
column = self.persepolis_setting.value('sort/column')
descending = self.persepolis_setting.value('sort/descending', False, type=bool)

if not column:
return

self.sort_desc = descending

if column == 'File Name':
self.sortByName()
elif column == 'Status':
self.sortByStatus()
elif column == 'Size':
self.sortBySize()
elif column == 'Downloaded':
self.sortByDownloaded()
elif column == 'Percentage':
self.sortByPercent()
elif column == 'First Try Date':
self.sortByFirstTry()
elif column == 'Last Try Date':
self.sortByLastTry()


# this method sorts download table by name
def sortByName(self, menu=None):

Expand All @@ -3200,7 +3278,7 @@ def sortByName2(self):
gid_name_dict[gid] = name

# sort names
gid_sorted_list = sorted(gid_name_dict, key=gid_name_dict.get)
gid_sorted_list = sorted(gid_name_dict, key=gid_name_dict.get, reverse=self.sort_desc)

# clear download_table and add sorted items
self.download_table.clearContents()
Expand Down Expand Up @@ -3256,6 +3334,8 @@ def sortByName2(self):
# update category_db_table
self.persepolis_db.updateCategoryTable([category_dict])

self.updateSortHeaderIndicator('File Name', descending=self.sort_desc)

# tell the CheckDownloadInfoThread that job is done!
global checking_flag
checking_flag = 0
Expand Down Expand Up @@ -3288,7 +3368,8 @@ def sortBySize2(self):
# convert file size to the Byte
try:
size_int = float(size_str[:-3])
size_symbol = str(size_str[-2])
size_symbol = str(size_str[-3])
print("symbol:" + size_symbol + " int:" + str(size_int))
if size_symbol == 'G':
size = size_int * 1073741824
elif size_symbol == 'M':
Expand All @@ -3306,7 +3387,7 @@ def sortBySize2(self):

# sort gid_size_dict
gid_sorted_list = sorted(
gid_size_dict, key=gid_size_dict.get, reverse=True)
gid_size_dict, key=gid_size_dict.get, reverse=self.sort_desc)

# clear download_table by size
self.download_table.clearContents()
Expand Down Expand Up @@ -3360,10 +3441,198 @@ def sortBySize2(self):
# update category_db_table
self.persepolis_db.updateCategoryTable([category_dict])

self.updateSortHeaderIndicator('Size', descending=self.sort_desc)

# tell the CheckDownloadInfoThread that job is done!
global checking_flag
checking_flag = 0

# this method sorts items in download_table by downloaded
def sortByDownloaded(self, menu=None):

# if checking_flag is equal to 1, it means that user pressed remove or
# delete button or ... . so checking download information must be
# stopped until job is done!
if checking_flag != 2:
wait_check = WaitThread()
self.threadPool.append(wait_check)
self.threadPool[-1].start()
self.threadPool[-1].QTABLEREADY.connect(self.sortByDownloaded2)
else:
self.sortByDownloaded2()

def sortByDownloaded2(self):

current_category_tree_text = str(current_category_tree_index.data())

# gid → downloaded size
gid_downloaded_dict = {}

for row in range(self.download_table.rowCount()):
downloaded_str = self.download_table.item(row, 3).text()
gid = self.download_table.item(row, 8).text()

# convert to bytes
try:
downloaded_int = float(downloaded_str[:-3])
downloaded_symbol = str(downloaded_str[-3])
if downloaded_symbol == 'G':
downloaded = downloaded_int * 1073741824
elif downloaded_symbol == 'M':
downloaded = downloaded_int * 1048576
elif downloaded_symbol == 'K':
downloaded = downloaded_int * 1024
else:
downloaded = downloaded_int
except ValueError:
downloaded = 0

gid_downloaded_dict[gid] = downloaded

# sort
gid_sorted_list = sorted(
gid_downloaded_dict,
key=gid_downloaded_dict.get,
reverse=self.sort_desc
)

# clear table
self.download_table.clearContents()

# get data again
if current_category_tree_text == 'All Downloads':
downloads_dict = self.persepolis_db.returnItemsInDownloadTable()
else:
downloads_dict = self.persepolis_db.returnItemsInDownloadTable(current_category_tree_text)

j = 0

for gid in gid_sorted_list:
download_info = downloads_dict[gid]

keys_list = [
'file_name',
'status',
'size',
'downloaded_size',
'percent',
'connections',
'rate',
'estimate_time_left',
'gid',
'link',
'first_try_date',
'last_try_date',
'category'
]

for i, key in enumerate(keys_list):
item = QTableWidgetItem(download_info[key])
self.download_table.setItem(j, i, item)

j += 1

# save order in DB
category_dict = {'category': current_category_tree_text}

gid_sorted_list.reverse()
category_dict['gid_list'] = gid_sorted_list

self.persepolis_db.updateCategoryTable([category_dict])

self.updateSortHeaderIndicator('Downloaded', descending=self.sort_desc)

global checking_flag
checking_flag = 0

# this method sorts items in download_table by percentage
def sortByPercent(self, menu=None):

# if checking_flag is equal to 1, it means that user pressed remove or
# delete button or ... . so checking download information must be
# stopped until job is done!
if checking_flag != 2:
wait_check = WaitThread()
self.threadPool.append(wait_check)
self.threadPool[-1].start()
self.threadPool[-1].QTABLEREADY.connect(self.sortByPercent2)
else:
self.sortByPercent2()

def sortByPercent2(self):

current_category_tree_text = str(current_category_tree_index.data())

gid_percent_dict = {}

for row in range(self.download_table.rowCount()):
percent_str = self.download_table.item(row, 4).text()
gid = self.download_table.item(row, 8).text()

# convert "45%" → 45
try:
percent = float(percent_str.replace('%', ''))
except ValueError:
percent = 0

gid_percent_dict[gid] = percent

# sort
gid_sorted_list = sorted(
gid_percent_dict,
key=gid_percent_dict.get,
reverse=self.sort_desc
)

# clear table
self.download_table.clearContents()

# reload data
if current_category_tree_text == 'All Downloads':
downloads_dict = self.persepolis_db.returnItemsInDownloadTable()
else:
downloads_dict = self.persepolis_db.returnItemsInDownloadTable(current_category_tree_text)

j = 0

for gid in gid_sorted_list:
download_info = downloads_dict[gid]

keys_list = [
'file_name',
'status',
'size',
'downloaded_size',
'percent',
'connections',
'rate',
'estimate_time_left',
'gid',
'link',
'first_try_date',
'last_try_date',
'category'
]

for i, key in enumerate(keys_list):
item = QTableWidgetItem(download_info[key])
self.download_table.setItem(j, i, item)

j += 1

# save order
category_dict = {'category': current_category_tree_text}

gid_sorted_list.reverse()
category_dict['gid_list'] = gid_sorted_list

self.persepolis_db.updateCategoryTable([category_dict])

self.updateSortHeaderIndicator('Percentage', descending=self.sort_desc)

global checking_flag
checking_flag = 0

# this method sorts download_table items with status
def sortByStatus(self, menu=None):

Expand Down Expand Up @@ -3406,7 +3675,7 @@ def sortByStatus2(self):
gid_status_dict[gid] = status_int

# sort gid_status_dict
gid_sorted_list = sorted(gid_status_dict, key=gid_status_dict.get)
gid_sorted_list = sorted(gid_status_dict, key=gid_status_dict.get, reverse=self.sort_desc)

# get download information from data base
if current_category_tree_text == 'All Downloads':
Expand Down Expand Up @@ -3460,6 +3729,8 @@ def sortByStatus2(self):
# update category_db_table
self.persepolis_db.updateCategoryTable([category_dict])

self.updateSortHeaderIndicator('Status', descending=self.sort_desc)

# tell the CheckDownloadInfoThread that job is done!
global checking_flag
checking_flag = 0
Expand Down Expand Up @@ -3502,7 +3773,7 @@ def sortByFirstTry2(self):

# sort
gid_sorted_list = sorted(
gid_try_dict, key=gid_try_dict.get, reverse=True)
gid_try_dict, key=gid_try_dict.get, reverse=self.sort_desc)

# clear download_table
self.download_table.clearContents()
Expand Down Expand Up @@ -3559,6 +3830,8 @@ def sortByFirstTry2(self):
# update category_db_table
self.persepolis_db.updateCategoryTable([category_dict])

self.updateSortHeaderIndicator('First Try Date', descending=self.sort_desc)

# tell the CheckDownloadInfoThread that job is done!
global checking_flag
checking_flag = 0
Expand Down Expand Up @@ -3604,7 +3877,7 @@ def sortByLastTry2(self):

# sort
gid_sorted_list = sorted(
gid_try_dict, key=gid_try_dict.get, reverse=True)
gid_try_dict, key=gid_try_dict.get, reverse=self.sort_desc)

# clear download_table
self.download_table.clearContents()
Expand Down Expand Up @@ -3661,6 +3934,8 @@ def sortByLastTry2(self):
# update category_db_table
self.persepolis_db.updateCategoryTable([category_dict])

self.updateSortHeaderIndicator('Last Try Date', descending=self.sort_desc)

# tell the CheckDownloadInfoThread that job is done!
global checking_flag
checking_flag = 0
Expand Down