fix: avoid spamming NewToolTip D-Bus signals on Wayland - #1128
Open
Artt4 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
checkDownloadInfo()runs every 200 ms and unconditionally callsQSystemTrayIcon.setToolTip(). On Wayland, Qt's StatusNotifierItem backend emits aNewToolTipD-Bus signal on every call, flooding the session bus with ~5 signals per second even when no downloads are active.This causes SNI-based tray hosts such as Waybar to stop displaying tooltips for all tray items while Persepolis is running.
Fix
Only call
setToolTip()when the tooltip text has actually changed. This keeps the download-progress tooltip working but eliminates the redundant D-Bus traffic.Testing
python3 ./test/test.py.