forked from ashkang/jcal
-
Notifications
You must be signed in to change notification settings - Fork 9
Bootstrapping (a minimal version of autogen.sh with no dep) #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Davoodeh
wants to merge
12
commits into
persiancal:master
Choose a base branch
from
Davoodeh:bootstrapping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2025
fzerorubigd
reviewed
Apr 5, 2025
Davoodeh
added a commit
to Davoodeh/jcal
that referenced
this pull request
Apr 5, 2025
This reverts commit 3832138. The namechange of autogen.sh will break build processes and should be delegated to another time as pointed by @fzerorubigd in persiancal#25 (comment)
Colors in the removed implementation are a reliability. Variables are can easily have typo (`YELLO`) and it clutters the code a lot. That aside, the color is just a bloated feature at this stage.
This commit is intended for documentation only. The full list should probably look like this. This command should not exist in the first place.
The user can use `git clean -fxd -'**/Makefile'` to achieve the same with more accuracy and no need to maintain a list of static files in any place in the project. The same can be done with a target like `clean-local: @-rm -rfdv ...` in makes but is it really even needed? Discussion is needed to add this back in one way or another.
Basically, remove extra functions that are glorified `|| exit` such as `check_services` and the whole SCREAMS.
Since there are no other flags, also remove --help.
Not to be confused with GNU AutoGen.
Davoodeh
added a commit
to Davoodeh/jcal
that referenced
this pull request
Apr 5, 2025
This reverts commit 3832138. The namechange of autogen.sh will break build processes and should be delegated to another time as pointed by @fzerorubigd in persiancal#25 (comment)
Rebased to resolve merge conflict. P.S: the hash was calculated incorrectly, pre-rebase, the new rebase just changes the commit description to use the new post-rebase hash |
This reverts commit ca31634. The namechange of autogen.sh will break build processes and should be delegated to another time as pointed by @fzerorubigd in persiancal#25 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having spent more time on the sources and recompiling the project over and over, I believe the old autogen (even my own POSIX version of #20) is a bloat and is better to be less of a liability.
This revision, while fixing #7, also changes its behavior and removes dependencies.