Add a minimalistic linter action #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action, triggered on push or pull, fails if clang-format fails. This addresses the comment referenced by [1] on persiancal#28 (formatting all the sources following the minimal path examples on persiancal#23). Note that the "sources" directory is hardcoded on the action file pushed. Assuming the change of source directory is a fundamental change with a lot of considerations, no documentations were added to mention that the value used in this file must be synchronized with the directory name on the tree. Suppose this comment suffices. [1]: persiancal#28 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action, triggered on push or pull, fails if clang-format fails. This addresses the comment referenced by 1 on #28 (formatting all the sources following the minimal path examples on #23).
Note that the "sources" directory is hardcoded on the action file pushed. Assuming the change of source directory is a fundamental change with a lot of considerations, no documentations were added to mention that the value used in this file must be synchronized with the directory name on the tree. Suppose this comment suffices.
After a bit of thinking, I realized adding a hook (as I previously suggested in my comment) is not a fit solution since it is hard to enforce on the user because of Git policies and still it just helps the developers not the maintainers so after a long 2 page scroll on Google I decided on this piece of work.
There is this run on my
workflow-lint-test-exampleas a failure example which may prove useful to study.P.S: I also tested Super Linter which is really wholesome in every sense but it is also too bloated just like Pre-Commit and honestly, after second 30 of build I scraped everything so I have no idea, maybe that is good too! Regardless, I don't think "checking" should take more time than "building", if that makes any sense. Since we have only C parts formatted yet, we can settle for this and consider expanding on this later. Or alternatively, all the Python and shell files will be removed before that day.