Fix viewer-charts context sharing and misc bugs
#1750
build.yaml
on: pull_request
Matrix: lint_and_docs
Matrix: build_js
Matrix: build_python
Matrix: build_and_test_rust
Matrix: build_emscripten_wheel
Matrix: benchmark_js
Matrix: test_js
Matrix: build_and_test_jupyterlab
Matrix: benchmark_python
Matrix: test_python
Matrix: test_emscripten_wheel
Matrix: test_python_sdist
Matrix: publish
Annotations
4 errors, 13 warnings, and 2 notices
|
test_js (ubuntu-22.04, 3.11, 22.x)
Process completed with exit code 1.
|
|
[viewer-datagrid-desktop-chrome] › packages/viewer-datagrid/test/js/column_style.spec.ts:261:5 › Column Style Tests › Column style label-bar on an expression column:
tools/test/src/js/utils.ts#L193
2) [viewer-datagrid-desktop-chrome] › packages/viewer-datagrid/test/js/column_style.spec.ts:261:5 › Column Style Tests › Column style label-bar on an expression column
Error: expect(string).toMatchSnapshot(expected) failed
@@ -12,18 +12,18 @@
>
<span>Order ID</span><span class="rt-column-resize"></span>
</th>
</tr>
<tr id="psp-column-edit-buttons">
- <th class="psp-menu-enabled psp-header-leaf psp-align-right">
+ <th class="psp-header-leaf psp-align-right psp-menu-enabled">
<span></span><span class="rt-column-resize"></span>
</th>
- <th class="psp-menu-enabled psp-header-leaf psp-align-right">
+ <th class="psp-header-leaf psp-align-right psp-menu-enabled">
<span></span><span class="rt-column-resize"></span>
</th>
<th
- class="psp-header-border psp-menu-enabled psp-header-leaf psp-align-left"
+ class="psp-header-border psp-header-leaf psp-align-left psp-menu-enabled"
>
<span></span><span class="rt-column-resize"></span>
</th>
</tr>
</thead>
Snapshot: column-style-tests-column-style-label-bar-on-an-expression-column.txt
at src/js/utils.ts:193
191 |
192 | snapshotPath = `${snapshotPath}.txt`;
> 193 | await expect(formatted).toMatchSnapshot(snapshotPath);
| ^
194 | }
195 |
196 | export async function compareSVGContentsToSnapshot(
at compareContentsToSnapshot (/home/runner/work/perspective/perspective/tools/test/src/js/utils.ts:193:29)
at /home/runner/work/perspective/perspective/packages/viewer-datagrid/test/js/column_style.spec.ts:289:9
|
|
[viewer-desktop-chrome] › rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:62:5 › Column Settings Sidebar › edit button > opens sidebar for active table and expression columns:
rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts#L83
1) [viewer-desktop-chrome] › rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:62:5 › Column Settings Sidebar › edit button > opens sidebar for active table and expression columns
TimeoutError: locator.click: Timeout 5000ms exceeded.
Call log:
- waiting for locator('perspective-viewer').locator('#active-columns :not(.top-panel) .column-selector-column').filter({ hasText: 'expr' }).first().locator('div .expression-edit-button')
81 | await activeColumns.scrollToBottom();
82 | exprCol.editBtn.waitFor();
> 83 | await exprCol.editBtn.click();
| ^
84 | await checkTab(view.columnSettingsSidebar, true, true);
85 | });
86 | test("edit button > opens sidebar for inactive expression columns", async ({
at /home/runner/work/perspective/perspective/rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:83:31
|
|
[viewer-desktop-chrome] › rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:62:5 › Column Settings Sidebar › edit button > opens sidebar for active table and expression columns:
rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts#L82
1) [viewer-desktop-chrome] › rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:62:5 › Column Settings Sidebar › edit button > opens sidebar for active table and expression columns
TimeoutError: locator.waitFor: Timeout 5000ms exceeded.
Call log:
- waiting for locator('perspective-viewer').locator('#active-columns :not(.top-panel) .column-selector-column').filter({ hasText: 'expr' }).first().locator('div .expression-edit-button') to be visible
80 |
81 | await activeColumns.scrollToBottom();
> 82 | exprCol.editBtn.waitFor();
| ^
83 | await exprCol.editBtn.click();
84 | await checkTab(view.columnSettingsSidebar, true, true);
85 | });
at /home/runner/work/perspective/perspective/rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:82:25
|
|
lint_and_docs (ubuntu-22.04, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/setup-node@v4, actions/setup-python@v5, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build_python (ubuntu-22.04-arm, aarch64, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build_and_test_rust (ubuntu-22.04, x86_64, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/setup-python@v5, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build_and_test_rust (ubuntu-22.04, x86_64, 22.x)
Cache paths are empty. Please check the previous logs and make sure that the python version is specified
|
|
build_and_test_rust (ubuntu-22.04, x86_64, 22.x)
The `python-version` input is not set. The version of Python currently in `PATH` will be used.
|
|
build_emscripten_wheel (ubuntu-22.04, x86_64, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/setup-python@v5, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build_python (ubuntu-22.04, x86_64, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
test_emscripten_wheel (ubuntu-22.04, x86_64, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/setup-python@v5, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
test_python (ubuntu-22.04, x86_64, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/setup-python@v5, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
test_python (ubuntu-22.04-arm, aarch64, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/setup-python@v5, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build_js (ubuntu-22.04, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build_and_test_jupyterlab (ubuntu-22.04, x86_64, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/setup-python@v5, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
test_js (ubuntu-22.04, 3.11, 22.x)
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/download-artifact@v4, actions/setup-node@v4, actions/upload-artifact@v4, pnpm/action-setup@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
🎭 Playwright Run Summary
3 passed (7.8s)
|
|
🎭 Playwright Run Summary
2 failed
[viewer-desktop-chrome] › rust/perspective-viewer/test/js/column_settings/sidebar.spec.ts:62:5 › Column Settings Sidebar › edit button > opens sidebar for active table and expression columns
[viewer-datagrid-desktop-chrome] › packages/viewer-datagrid/test/js/column_style.spec.ts:261:5 › Column Style Tests › Column style label-bar on an expression column
118 skipped
1720 passed (4.4m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
perspective-js-dist
|
10.8 MB |
sha256:e8f0bde25a51aaf174009a6260982428c2e33692e78d4afedc4dc0fa5b7496c1
|
|
|
perspective-js-test-results
|
9.16 KB |
sha256:78aa6428308dc75e1e3072be9437dc1896f55458fa272e4b110ceb149884d986
|
|
|
perspective-metadata
|
660 KB |
sha256:ae9d0316fd6688e03ec694eef2261f75078a795b4a91c55394f4472a53238267
|
|
|
perspective-python-dist-aarch64-ubuntu-22.04-arm-3.11
|
5.85 MB |
sha256:b1cd6067a70dc82e0d9a59c3d899150696f4e0467ba5440a2358a5db28c278a5
|
|
|
perspective-python-dist-wasm32-emscripten-3.11
|
3.11 MB |
sha256:73573d73e43f74cfc49c06c5af4d138d9d85538479117fc63ce8094d925b60fa
|
|
|
perspective-python-dist-x86_64-ubuntu-22.04-3.11
|
9.4 MB |
sha256:5b5ef3846c3c4b44251b773c860f95b1da62aa94532e34ef1f97bf70499a73b5
|
|
|
perspective-python-sdist
|
3.59 MB |
sha256:6a126d7a90fc6518177abad6b035e5e236080c8157ee16c70102434d584d1139
|
|
|
perspective-rust
|
1.06 MB |
sha256:3d724d2cd1879419ecc4902268a73748b3c9e2d9ea33980495e52650cdcb24a7
|
|