Fix last row label state after collapse and expand#2895
Closed
tarekquao wants to merge 2 commits intoperspective-dev:masterfrom
Closed
Fix last row label state after collapse and expand#2895tarekquao wants to merge 2 commits intoperspective-dev:masterfrom
tarekquao wants to merge 2 commits intoperspective-dev:masterfrom
Conversation
Signed-off-by: Tarek Quao <tarek.quao@turntabl.io>
Signed-off-by: Tarek Quao <tarek.quao@turntabl.io>
texodus
reviewed
Feb 10, 2025
| const totalHeader = await page.locator('th:has-text("TOTAL")').first(); | ||
|
|
||
| await totalHeader.click(); | ||
| await totalHeader.click(); |
texodus
reviewed
Feb 10, 2025
| dy: metadata.y - metadata.y0 + 1, | ||
| }); | ||
|
|
||
| const is_last_item = !next || next.row_header === undefined; |
Member
There was a problem hiding this comment.
This only checks whether the row is the last row in the viewport, not the dataset. it just makes the last row visible on screen always appear folded.
Screen.Recording.2025-02-09.at.9.03.15.PM.mov
Member
|
Thanks for the PR, but I don't think this approach is going to work. I can see two potential approaches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue found in #2368 where in a grouped state (within Datagrid), the last grouped row header seemed as if it had been already unfolded showing the (-) sign instead of the (+) sign.
Now the last grouped row rightly shows the (+) sign.
Pull Request Checklist
Discussions, this PR applies to.