Add some native HTML attributes to perspective-react#3010
Merged
Conversation
Signed-off-by: Andrew Stein <steinlink@gmail.com>
9940c3f to
99797fb
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
33c4a67 to
556d3ab
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
1e0f90e to
1066773
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
id,classNameand a few other pass-through attributes for@finos/perspective-react. Perspective's props cannot inherit fromReact.HTMLAttributesdue to conflicting definitions foronClickandonSelect, which I do not feel like resolving in this release (and many HTML attributes are not directly applicable to<perspective-viewer>anyway).Adds new static accessors for Perspecitve Custom Elements
max_cellsandmax_columnsrender limits flags, and adds tests and docs for render limits configuration, e.g.:or
Adds
data-xanddata-ydataset attributes to@finos/perspective-viewer-datagrid's internal table rendering, such that CSS rules may be made aware of the table's virtual dimensions.Port all UI elements Custom Elements implementations to use
adoptedStyleSheetsrather than inline<style>tags, which offers both a widget-load-performance boost as well as a simpler mechanism for extending Perspective' internal style rules.Update's the test suite to allow finer-grained debugging for large HTML diffs.