Fix "Export to HTML" feature in @perspective-dev/viewer component#3095
Merged
Fix "Export to HTML" feature in @perspective-dev/viewer component#3095
@perspective-dev/viewer component#3095Conversation
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3094
In #3065, we renamed (seemingly endless) references to
@finospackages to their new@perspective-devNPM org, but despite passing the entire test suite one instance slipped - the CDN URL templating for<perspective-viewer>'s export-to-html feature.I'm not sure the best way to test this, since the artifact produced sources from CDN - suggestions welcome.
In addition, a few drive-by fixes: