Conversation
texodus
force-pushed
the
fix-null-equality-bug
branch
2 times, most recently
from
9c3403b to
324a7bf
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
fix-null-equality-bug
branch
from
324a7bf to
82f21a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue which caused
nullvalues in separatetable.update()batches to not be assigned the correct group if aViewwith agroup_byalready exists. Also included is a convoluted test that repros this condition through brute force.