Give the v4 workflow its own file name - #2990
Merged
Merged
Conversation
Renaming the workflow in #2989 was not enough. A workflow is identified by its file path, and the name comes from the copy on the default branch, so this file was still labelled "CI" because main has a ci.yml. test-report.yml on main runs after every workflow named "CI", and it failed on every v4 run, Pester 4 writes NUnit 2.5 XML that dorny/test-reporter cannot read. ci.yml becomes ci-v4.yml, which makes it a separate workflow with its own name. The gate job is still "Done". 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2989, the rename there did not do what I thought.
A workflow is identified by its file path, and its display name comes from the copy on the default branch. Since main now has
.github/workflows/ci.yml, this branch's file at the same path is still labelledCI, no matter whatname:says in it. Sotest-report.ymlon main, which runs after every workflow namedCI, kept firing for v4 runs and failing: Pester 4 writes NUnit 2.5 XML and dorny/test-reporter cannot read it. The run right after #2989 merged shows it, https://github.com/pester/Pester/actions/runs/32568961399.ci.ymlbecomesci-v4.ymlhere, which makes it a workflow of its own with its own name. The gate job is stillDone, so branch protection is unaffected.🤖