fix: beforeEach/afterEach leaking into sibling describe blocks with same nested name - #1850
Open
one-git-wonder wants to merge 1 commit into
Open
fix: beforeEach/afterEach leaking into sibling describe blocks with same nested name#1850one-git-wonder wants to merge 1 commit into
one-git-wonder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
beforeEach/afterEach hooks registered inside a nested describe block leaked into tests in a sibling describe block that shared the same inner describe name, producing misleading ErrorException: Undefined property errors.
Replace the loose membership check with a strict prefix check. A hook now fires only if its entire describe path is a prefix of the test's describe path, which correctly scopes hooks to their own hierarchy while still allowing outer describe hooks to cascade into nested describes.
Related:
#1522