Harden OpenAI-compatible embedding provider support - #194
Merged
Aaronontheweb merged 3 commits intoJun 26, 2026
Merged
Conversation
Operators want to point Memorizer at hosted OpenAI or any OpenAI-compatible gateway (LiteLLM, vLLM, Azure OpenAI, LocalAI) without standing up Ollama. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #193 and preserves the contributor's OpenAI-compatible embeddings work while addressing provider migration and credential handling concerns.\n\nCloses #193.\n\n## Summary\n- Add OpenAI-compatible embedding request/response support alongside Ollama.\n- Apply active embedding provider settings before dimension validation on save/activation.\n- Keep embedding API keys sourced from runtime configuration only, not provider_settings JSON.\n- Redact and recursively strip sensitive provider config keys before API display or database storage.\n- Add a migration to remove any previously persisted provider API keys from provider_settings.config.\n- Make fallback embedding dimensions schema-safe during dimension migrations.\n- Add focused unit tests for provider request auth and config sanitization.\n\n## Testing\n- git diff --check\n- dotnet test src/Memorizer.UnitTests/Memorizer.UnitTests.csproj --filter "EmbeddingApiClientTests|ProviderConfigSanitizerTests" --no-restore could not run locally because global.json requires .NET SDK 10.0.102, which is not installed in this environment.