fix(board): preserve sessions when panel restore fails#176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #174 by making runtime-state restoration tolerant of individual panel spawn failures.
When one panel cannot be restored, Horizon now:
Root Cause
Board::from_runtime_state_with_transcripts() used ? while restoring each panel, so any single create_panel() failure aborted the whole board restore. The UI then caught that board-level error and replaced the session with Board::new(), making every panel appear lost even though runtime.yaml still existed.
Validation
Note: while investigating corrupt or missing Codex binaries, I found that some executable failures can surface as fast child exits instead of parent-side PTY spawn errors on macOS. This PR fixes the board-abort path described in the issue: any restore-time create_panel() error no longer takes down the full session.