fix(panel): never auto-close panels on child exit#185
Merged
Conversation
Previously a clean process exit (exit code 0, e.g. typing `exit` in a shell or Ctrl-D / Ctrl-C-then-exit in an agent) auto-removed the panel. PR #180 already kept failed exits open; this finishes the job for the success case so the user always closes panels manually via the X button or the "Close" context menu item. Drops the `should_close_after_exit` / `should_close_for_exit_status` machinery and `Board::exited_panels`, plus the lifecycle hook that fed exited ids into `panels_to_close`. SSH "Reconnect" still works: SSH panels were already exempted from auto-close, and the `child_exited()` flag (used to flip `SshConnectionStatus` to `Disconnected`) is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0) still auto-removed the panel:exitin a shell,Ctrl-D//exitin an agent, or any successful one-shot command would make the panel vanish.Panel::should_close_after_exit, theshould_close_for_exit_statushelper,Board::exited_panels, and the lifecycle loop that fed exited ids intopanels_to_close.child_exited()(used to flipSshConnectionStatus::Disconnected) is untouched.Test plan
exit, confirm the panel stays open and can be closed via the X./exit(or Ctrl-C thenexit), confirm the panel stays open.echo hi), confirm the panel stays open after the command finishes.exit), confirm the panel stays open and Reconnect still works.